fixed unexpected learn more button behaviour in chrome #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the border property from learn-more class
|
@alexdor reviews? |
|
Nice work : ) There is a border at the bottom that wasn’t there before, could you also fix that? |
|
@alexdor I noticed that in firefox the issue is fixed but in chrome at 200% page zoom, there is still a white line |
alexdor
reviewed
Oct 21, 2018
|
@alexdor fixed it, once and for all |
|
Looks good @himankpathak : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
White line at the right edge of the button appeared in chrome browser due to border property set to 0 in
learn-moreclass due to which it was inheriting property from its parent, which was really insignificant and uncalled for.Current Issue:
Removed the border property from the
learn-moreclass and the bug was fixed.Verification Process
After fix on Firefox:
After fix on Chrome:
Concerned Issues
W.R.T. #28