Skip to content

Conversation

@conorcode
Copy link

Hello,

This is my first pull request!

I used the CSS transition Property for a smooth transition and footer:hover to change the height.

@ostheperson
Copy link
Owner

conorcode, I tested your commit.
Bad News - You ultimately did not do the task. (You did the exact opposite). You are to make the majority of it invisible leaving/exposing only a small part of the top visible for the user to know there is something there.

Good News - What you did opens up a new series of features. e.g adding mini news boxes that reload whenever the user closes and opens the footer.

Lastly, there has been some merged Pull Request(s) since you made this commit ensure to merge the changes locally and when you complete the task make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants