New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[memory][scs][parser] Don't generate arcs from sc-element classes #434

Merged

NikitaZotov merged 19 commits into ostis-ai:main from NikitaZotov:feat/skip_generating_type_arcs

Jan 17, 2025

Member

NikitaZotov commented Nov 11, 2024 •

edited

Loading

Read PR documentation
Update changelog
Update documentation

Now, sc-arcs between sc-element types and sc-elements are not generated in sc-memory. This allows for:

fixing cases where these sc-arcs belong to sc-structures (in particular, sc-templates) and hinder the processing of these sc-templates (searching by sc-template);
improving visualization of the semantic neighborhoods of certain types of sc-elements.

NikitaZotov self-assigned this

NikitaZotov added scs 0.10.0 labels

NikitaZotov force-pushed the feat/skip_generating_type_arcs branch 3 times, most recently from 98d16df to 6ac65a8 Compare

November 11, 2024 21:41

NikitaZotov requested a review from kilativ-dotcom

November 11, 2024 21:48

codecov bot commented Nov 11, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 97.99107% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.54%. Comparing base (53fbce9) to head (2ddb74d).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   95.49%   95.54%   +0.05%     
==========================================
  Files         236      236              
  Lines       26037    26419     +382     
  Branches     1827     1837      +10     
==========================================
+ Hits        24863    25241     +378     
- Misses       1174     1178       +4

kilativ-dotcom requested changes

View reviewed changes

docs/changelog.md Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/sc_scs_helper.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/sc_scs_helper.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

NikitaZotov force-pushed the feat/skip_generating_type_arcs branch 2 times, most recently from c053422 to b1904dc Compare

November 14, 2024 22:40

NikitaZotov requested a review from kilativ-dotcom

November 14, 2024 22:46

kilativ-dotcom reviewed

View reviewed changes

sc-memory/sc-memory/include/sc-memory/scs/scs_parser.hpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/tests/scs/units/test_scs_alias.cpp Show resolved Hide resolved

sc-memory/sc-memory/tests/scs/units/test_scs_alias.cpp Show resolved Hide resolved

sc-memory/sc-memory/tests/scs/units/test_scs_common.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/tests/scs/units/test_scs_common.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/sc_template_scs.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/sc_scs_helper.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/sc_scs_helper.cpp Outdated Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

November 15, 2024 11:08

NikitaZotov added the sc-template-build label

kilativ-dotcom requested changes

View reviewed changes

sc-memory/sc-memory/include/sc-memory/scs/scs_parser.hpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/tests/sc-memory/units/templates/test_sc_templates_scs.cpp Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

November 21, 2024 09:07

kilativ-dotcom reviewed

View reviewed changes

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

November 22, 2024 17:25

kilativ-dotcom requested changes

View reviewed changes

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

November 26, 2024 13:20

NikitaZotov added this to the 0.10.0 milestone

kilativ-dotcom requested changes

View reviewed changes

sc-memory/sc-memory/src/scs/scs_parser.cpp Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

December 2, 2024 12:29

kilativ-dotcom requested changes

View reviewed changes

Member

kilativ-dotcom left a comment

left comment in a thread

NikitaZotov requested a review from kilativ-dotcom

December 2, 2024 14:14

kilativ-dotcom requested changes

View reviewed changes

Member

kilativ-dotcom left a comment

left comment in a thread

NikitaZotov requested a review from kilativ-dotcom

December 3, 2024 08:33

kilativ-dotcom requested changes

View reviewed changes

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

NikitaZotov force-pushed the feat/skip_generating_type_arcs branch from e1bf70b to d617099 Compare

December 5, 2024 23:32

NikitaZotov requested a review from kilativ-dotcom

December 29, 2024 15:45

kilativ-dotcom requested changes

View reviewed changes

sc-memory/sc-memory/tests/scs/units/test_scs_common.cpp Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/src/scs/scs_parser.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/tests/sc-memory/units/scs-helper/test_scs_helper.cpp Outdated Show resolved Hide resolved

sc-memory/sc-memory/tests/sc-memory/units/scs-helper/test_scs_helper.cpp Outdated Show resolved Hide resolved

NikitaZotov requested a review from kilativ-dotcom

January 13, 2025 14:40

kilativ-dotcom reviewed

View reviewed changes

Member

kilativ-dotcom left a comment

need to decide on constancy subtypes

NikitaZotov requested a review from kilativ-dotcom

January 16, 2025 09:35

kilativ-dotcom requested changes

View reviewed changes

Member

kilativ-dotcom left a comment

resolve conflicts

NikitaZotov added 18 commits

January 17, 2025 17:20


          [memory][scs][parser] Don't generate arcs from sc-element classes

ddbae16


          [docs] Apply changes

614994e


          [memory][scs][tests] Check that arc between type of sc-element and sc…

b999961

…-element is not generated


          [memory][scs][tests] Don't ignore arcs to types of elements nodes

9c343c8


          [memory][scs][tests] Throw errors if element types are used incorrectly

0b11a8d


          [memory][template][scs][build][tests] Clarify exception if element is…

6b9236a

… not found


          [memory][scs][tests] Don't allows arcs from to arcs from sc-element t…

b52c661

…ypes only


          [memory][scs][tests] Add sc-arcs from structure to element types if e…

0dad548

…lement types have not only outgoig base sc-arcs


          [memory][scs][tests] Fix duplicating adding sc-element types to struc…

b285359

…ture; fix adding triples with two sc-element types; fix adding hanging sc-element types


          [memory][scs] Use multimap instead of unordered_multimap to avoid cor…

38e7b65

…e dumped


          [memory][scs] Check types of sc-elements denoting sc-elements types

8ca4b4f


          [memory][scs][tests] Check extendability to sc.s-types

300f8fd


          [memory][scs][tests] Check that type of sc-elements can be extended t…

6ea28d5

…o sc-element type


          [memory][scs][tests] Check const and var masks

d9dec69


          [memory][scs] Clarify checks for extendability of source and target e…

6f07456

…lement with and withour constancy masks


          [memory][scs][tests] Tests const and var masks

6baca52


          [memory][scs][tests] Review var and object names, comments

dc10bf6


          [refactor][memory][scs] Clarify names for vars with constancy of sour…

ea697e8

…ce and target types

NikitaZotov force-pushed the feat/skip_generating_type_arcs branch from b926ce1 to 93b0912 Compare

January 17, 2025 14:21

NikitaZotov requested a review from kilativ-dotcom

January 17, 2025 14:22


          [refactor] Format sources with scs substring

4ec0854

NikitaZotov force-pushed the feat/skip_generating_type_arcs branch from 93b0912 to 4ec0854 Compare

January 17, 2025 14:27

kilativ-dotcom approved these changes

View reviewed changes

NikitaZotov merged commit 5b4a3d0 into ostis-ai:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.10.0 sc-template-build scs