Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conan cd and docs #458

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Jan 15, 2025


Important

Integrate Conan package management into GitHub Actions and update documentation for Conan usage.

  • GitHub Actions:
    • Add steps in release.yml to set Conan remote, create and upload Conan package.
  • Documentation:
    • Update build_system.md to include Conan remote setup instructions.
    • Update quick_start.md to include Conan remote setup instructions.
    • Minor punctuation fixes in build_system.md.

This description was created by Ellipsis for 6fd6669. It will automatically update as commits are pushed.

@NikitaZotov NikitaZotov self-assigned this Jan 15, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6fd6669 in 12 seconds

More details
  • Looked at 67 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/build/build_system.md:141
  • Draft comment:
    Consider defining the Conan remote URL in a single location and referencing it to avoid repetition and potential inconsistencies. This comment applies to other occurrences in release.yml and quick_start.md.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The Conan remote URL is repeated multiple times across different files. It's better to define it once and reference it to avoid inconsistencies.

Workflow ID: wflow_fgbgcBCX3zguEQ9g


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NikitaZotov NikitaZotov changed the title feat: update conan cd and docs [ci][docs] Update conan cd and docs Jan 15, 2025
@NikitaZotov NikitaZotov changed the title [ci][docs] Update conan cd and docs Update conan cd and docs Jan 15, 2025
@NikitaZotov NikitaZotov added this to the 0.10.0 milestone Jan 15, 2025
@NikitaZotov NikitaZotov added 0.10.0 ci CI is enhanced documentation Improvements or additions to documentation labels Jan 15, 2025
@NikitaZotov NikitaZotov requested a review from KovalM January 15, 2025 22:58
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (1424e78) to head (8a3db87).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         237      237           
  Lines       26965    26965           
  Branches     1863     1862    -1     
=======================================
  Hits        25808    25808           
  Misses       1157     1157           

docs/build/build_system.md Outdated Show resolved Hide resolved
@NikitaZotov NikitaZotov requested a review from KovalM January 17, 2025 14:24
@NikitaZotov NikitaZotov merged commit dbcc8c3 into ostis-ai:main Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.0 ci CI is enhanced documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants