-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conan cd and docs #458
Update conan cd and docs #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6fd6669 in 12 seconds
More details
- Looked at
67
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. docs/build/build_system.md:141
- Draft comment:
Consider defining the Conan remote URL in a single location and referencing it to avoid repetition and potential inconsistencies. This comment applies to other occurrences inrelease.yml
andquick_start.md
. - Reason this comment was not posted:
Confidence changes required:50%
The Conan remote URL is repeated multiple times across different files. It's better to define it once and reference it to avoid inconsistencies.
Workflow ID: wflow_fgbgcBCX3zguEQ9g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 237 237
Lines 26965 26965
Branches 1863 1862 -1
=======================================
Hits 25808 25808
Misses 1157 1157 |
Important
Integrate Conan package management into GitHub Actions and update documentation for Conan usage.
release.yml
to set Conan remote, create and upload Conan package.build_system.md
to include Conan remote setup instructions.quick_start.md
to include Conan remote setup instructions.build_system.md
.This description was created by for 6fd6669. It will automatically update as commits are pushed.