Skip to content

Commit

Permalink
feat(json): remove Locale & Currency & Money as json primary types
Browse files Browse the repository at this point in the history
  • Loading branch information
yankun1992 committed Aug 3, 2024
1 parent f00c499 commit b5fb596
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 96 deletions.
12 changes: 0 additions & 12 deletions serde-json/src/cc/otavia/json/JsonHelper.scala
Original file line number Diff line number Diff line change
Expand Up @@ -377,23 +377,11 @@ private[json] object JsonHelper {
out.writeByte('\"')
}

final def serializeLocale(locale: Locale, out: Buffer): Unit = ???

final def serializeCurrency(currency: Currency, out: Buffer): Unit = ???

final def deserializeUUID(in: Buffer): UUID = {
assert(in.skipIfNextIs('\"'), s"except \" but get ${in.readByte.toChar}")
val uuid = BufferUtils.readStringAsUUID(in)
assert(in.skipIfNextIs('\"'), s"except \" but get ${in.readByte.toChar}")
uuid
}

final def deserializeLocale(in: Buffer): Locale = ???

final def deserializeCurrency(in: Buffer): Currency = ???

final def serializeMoney(money: Money, out: Buffer): Unit = ???

final def deserializeMoney(in: Buffer): Money = ???

}
21 changes: 0 additions & 21 deletions serde-json/src/cc/otavia/json/JsonSerde.scala
Original file line number Diff line number Diff line change
Expand Up @@ -277,29 +277,8 @@ trait JsonSerde[A] extends Serde[A] with SerdeOps {
this
}

override final protected def serializeLocale(locale: Locale, out: Buffer): this.type = {
JsonHelper.serializeLocale(locale, out)
this
}

override final protected def serializeCurrency(currency: Currency, out: Buffer): this.type = {
JsonHelper.serializeCurrency(currency, out)
this
}

override final protected def deserializeUUID(in: Buffer): UUID = JsonHelper.deserializeUUID(in)

override final protected def deserializeLocale(in: Buffer): Locale = JsonHelper.deserializeLocale(in)

override final protected def deserializeCurrency(in: Buffer): Currency = JsonHelper.deserializeCurrency(in)

override final protected def serializeMoney(money: Money, out: Buffer): this.type = {
JsonHelper.serializeMoney(money, out)
this
}

override final protected def deserializeMoney(in: Buffer): Money = JsonHelper.deserializeMoney(in)

}

object JsonSerde {
Expand Down
63 changes: 0 additions & 63 deletions serde/src/cc/otavia/serde/SerdeOps.scala
Original file line number Diff line number Diff line change
Expand Up @@ -599,28 +599,6 @@ trait SerdeOps {
*/
protected def serializeUUID(uuid: UUID, out: Buffer): this.type

/** Serialize [[Locale]] value to [[Buffer]].
*
* @param locale
* Value.
* @param out
* Output [[Buffer]].
* @return
* This [[Serde]] instance.
*/
protected def serializeLocale(locale: Locale, out: Buffer): this.type

/** Serialize [[Currency]] value to [[Buffer]].
*
* @param currency
* Value.
* @param out
* Output [[Buffer]].
* @return
* This [[Serde]] instance.
*/
protected def serializeCurrency(currency: Currency, out: Buffer): this.type

/** Deserialize [[UUID]] value from [[Buffer]].
*
* @param in
Expand All @@ -630,45 +608,4 @@ trait SerdeOps {
*/
protected def deserializeUUID(in: Buffer): UUID

/** Deserialize [[Locale]] value from [[Buffer]].
*
* @param in
* Input [[Buffer]]
* @return
* [[Locale]] value.
*/
protected def deserializeLocale(in: Buffer): Locale

/** Deserialize [[Currency]] value from [[Buffer]].
*
* @param in
* Input [[Buffer]]
* @return
* [[Currency]] value.
*/
protected def deserializeCurrency(in: Buffer): Currency

//// otavia common data types
// serialize ops

/** Serialize [[Money]] value to [[Buffer]].
*
* @param money
* Value.
* @param out
* Output [[Buffer]].
* @return
* This [[Serde]] instance.
*/
protected def serializeMoney(money: Money, out: Buffer): this.type

/** Deserialize [[Money]] value from [[Buffer]].
*
* @param in
* Input [[Buffer]]
* @return
* [[Money]] value.
*/
protected def deserializeMoney(in: Buffer): Money

}

0 comments on commit b5fb596

Please sign in to comment.