Release v0.4.2

- Bugfix/Now the filters VO is correctly serialized with array values.
othercodes · Apr 26, 2021 · 9870785 · 9870785
2 parents 550aae2 + 14e6027
commit 9870785
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/Domain/Criteria/Filter.php b/src/Domain/Criteria/Filter.php
@@ -87,7 +87,7 @@ final protected function invariantOperatorValueMustBeOneOfTheList(): bool
      *
      * @param  string  $field
      * @param  string  $operator
-     * @param  mixed   $value
+     * @param  mixed  $value
      *
      * @return Filter
      */
@@ -121,6 +121,13 @@ public function value()
 
     public function __toString(): string
     {
-        return sprintf('%s.%s.%s', $this->field(), $this->operator(), $this->value());
+        return sprintf(
+            '%s.%s.%s',
+            $this->field(),
+            $this->operator(),
+            is_array($this->value())
+                ? implode('|', $this->value())
+                : $this->value()
+        );
     }
 }
diff --git a/tests/Domain/Criteria/CriteriaTest.php b/tests/Domain/Criteria/CriteriaTest.php
@@ -23,7 +23,7 @@ public function testShouldBuildCriteriaSuccessfully(): void
         $criteria = new Criteria(
             FilterGroup::create(
                 [
-                    ['name', '=', 'Marsellus'],
+                    ['name', 'in', ['Marsellus', 'Mia']],
                     ['surname', '=', 'Wallace'],
                 ]
             ),
@@ -44,7 +44,7 @@ public function testShouldBuildCriteriaSuccessfully(): void
         $this->assertEquals(100, $criteria->pageOffset());
 
         $this->assertEquals(
-            "name.=.Marsellus+surname.=.Wallace#name.asc#100.100",
+            "name.in.Marsellus|Mia+surname.=.Wallace#name.asc#100.100",
             (string)$criteria
         );
     }