feat: deal with legacy rating

otohime-site · Jul 26, 2021 · ab180cb · ab180cb
1 parent 0fda452
commit ab180cb
Show file tree

Hide file tree

Showing 4 changed files with 74 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@otohime-site/parser",
-  "version": "21.7.1",
+  "version": "21.7.2",
   "license": "MIT",
   "main": "index.js",
   "types": "index.d.ts",

diff --git a/src/dx_intl/player.ts b/src/dx_intl/player.ts
@@ -3,6 +3,9 @@ import { assertNonEmpty, assertBetween } from "../utils"
 interface PlayerParseResultBase {
   card_name: string
   rating: number
+  // Who did not play the new version yet
+  // will stay the previous rating
+  rating_legacy: boolean
   title: string
   trophy: "normal" | "bronze" | "silver" | "gold" | "rainbow"
 }
@@ -16,6 +19,16 @@ export interface PlayerParseResultNew extends PlayerParseResultBase {
   class_rank: number
 }
 
+const isLegacyRating = (rating: number, ref: string): boolean =>
+  (ref === "green" && rating < 3000) ||
+  (ref === "orange" && rating < 4000) ||
+  (ref === "red" && rating < 7000) ||
+  (ref === "purple" && rating < 10000) ||
+  (ref === "bronze" && rating < 12000) ||
+  (ref === "silver" && rating < 13000) ||
+  (ref === "gold" && rating < 14000) ||
+  (ref === "rainbow" && rating < 15000)
+
 const parsePlayer = (
   content: string | HTMLDocument
 ): PlayerParseResultLegacy | PlayerParseResultNew => {
@@ -37,6 +50,10 @@ const parsePlayer = (
   ])[0].toLowerCase()
   const ratingBlock = document.querySelector(".rating_block")
   const rawRating = ratingBlock?.textContent ?? ""
+  const ratingImageRef = (document
+    .querySelector('img[src *= "/img/rating_base_"]')
+    ?.getAttribute("src")
+    ?.match(/_([a-z]+)\.png/) ?? ["", ""])[1]
   const rawCourseRank = (document
     .querySelector('img[src *= "/img/course/"]')
     ?.getAttribute("src")
@@ -53,6 +70,8 @@ const parsePlayer = (
   assertNonEmpty(title, "title")
   assertNonEmpty(trophy, "trophy")
   assertNonEmpty(rawRating, "rating")
+  assertNonEmpty(ratingImageRef, "ratingImageRef")
+
   if (
     rawGrade.length === 0 &&
     (rawCourseRank.length === 0 || rawClassRank.length === 0)
@@ -83,6 +102,7 @@ const parsePlayer = (
       title,
       trophy,
       rating,
+      rating_legacy: isLegacyRating(rating, ratingImageRef),
       grade,
     }
   }
@@ -99,6 +119,7 @@ const parsePlayer = (
     title,
     trophy,
     rating,
+    rating_legacy: isLegacyRating(rating, ratingImageRef),
     course_rank: courseRank,
     class_rank: classRank,
   }

diff --git a/tests/dx_intl.test.ts b/tests/dx_intl.test.ts
@@ -79,6 +79,42 @@ const playerContentNewVersion = `
 </div>
 `
 
+const playerContentNewVersionAndRating = `
+<div class="see_through_block m_15 m_t_0 p_10 p_r t_l f_0">
+	<div class="basic_block p_10 f_0">
+		<img src="https://maimaidx.jp/maimai-mobile/img/Icon/513dc5cb9f0ca1c7.png" class="w_112 f_l"/>
+		<div class="p_l_10 f_l">
+			<div class="trophy_block trophy_Bronze p_3 t_c f_0">
+				<div class="trophy_inner_block f_13">
+					<span>京都府勢</span>
+				</div>
+			</div>
+		<div class="m_b_5">
+			<div class="name_block f_l f_16">ＫＯＩＮＵ</div>
+			<div class="f_r t_r f_0">
+				<div class="p_r p_3">
+					<img src="https://maimaidx.jp/maimai-mobile/img/rating_base_gold.png?ver=1.17" class="h_30 f_r"/>
+					<div class="rating_block f_11">14323</div>
+				</div>
+			</div>
+			<div class="clearfix"></div>
+		</div>
+		<img src="https://maimaidx.jp/maimai-mobile/img/line_01.png" class="user_data_block_line" />
+		<div class="clearfix"></div>
+		<img src="https://maimaidx.jp/maimai-mobile/img/course/course_rank_01T7GHJvGe.png" class="h_35 f_l"/>
+		<img src="https://maimaidx.jp/maimai-mobile/img/class/class_rank_s_04ZqZmdpb8.png" class="p_l_10 h_35 f_l">
+		<div class="p_l_10 f_l f_14"><img src="https://maimaidx.jp/maimai-mobile/img/icon_star.png" class="h_30 m_3 v_m"/>×3</div>
+		</div>
+		<div class="clearfix"></div>
+	</div>
+	<img src="https://maimaidx.jp/maimai-mobile/img/Chara/a58681dff962bf96.png" class="w_120 m_t_10 f_r"/>
+		<div class="comment_block f_l f_12">
+		
+	</div>
+	<div class="clearfix"></div>
+</div>
+`
+
 const scoresContent = `
 <div class="wrapper main_wrapper t_c">
   <div class="screw_block m_15 f_15">POPS &amp; ANIME</div>
@@ -129,6 +165,7 @@ test("Player should parse successfully", () => {
     title: "Test Title",
     trophy: "gold",
     rating: 8500,
+    rating_legacy: true,
     grade: 13,
   })
 })
@@ -138,6 +175,7 @@ test("Player should parse successfully if title is a marquee", () => {
     title: "打打打打打打打打打打打打打打打打打打打打打打打打",
     trophy: "bronze",
     rating: 10100,
+    rating_legacy: true,
     grade: 21,
   })
 })
@@ -147,6 +185,18 @@ test("We should be able to parse the new version player", () => {
     title: "京都府勢",
     trophy: "bronze",
     rating: 5316,
+    rating_legacy: true,
+    course_rank: 1,
+    class_rank: 4,
+  })
+})
+test("We should be able to parse the new version player and rating", () => {
+  expect(parsePlayer(playerContentNewVersionAndRating)).toEqual({
+    card_name: "ＫＯＩＮＵ",
+    title: "京都府勢",
+    trophy: "bronze",
+    rating: 14323,
+    rating_legacy: false,
     course_rank: 1,
     class_rank: 4,
   })