Skip to content

Update links! #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cansavvy merged 4 commits into from
Apr 4, 2025
Merged

Update links! #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
422a692
Update links
cansavvy Apr 2, 2025
6b1773f
Apply suggestions from code review
cansavvy Apr 4, 2025
c7296ef
Update Dockerfile
cansavvy Apr 4, 2025
cc46a6e
Update Dockerfile
cansavvy Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Read the README and Code of Conduct in this repository to get started.

If you have an idea for a new Docker image needed here, please create an issue and tag @cansavvy or @kweav.
After discussion we can tell you if your idea for a Docker image is potnetially met by an existing image or will require a new image.
If it requires a new image, you are welcome to file a pull request with a new Dockerfile [following the instructions here](https://github.com/jhudsl/ottr-docker?tab=readme-ov-file#adding-a-new-image)
If it requires a new image, you are welcome to file a pull request with a new Dockerfile [following the instructions here](https://github.com/ottrproject/ottr-docker?tab=readme-ov-file#adding-a-new-image)

After you file this pull request and it passes the incoming Dockerfile build test, tag @cansavvy to review it.
Contact @cansavvy with any additional questions!
3 changes: 1 addition & 2 deletions base_ottr/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ RUN gdebi --non-interactive quarto-linux-amd64.deb
RUN Rscript -e "devtools::install_version('gitcreds', version = '0.1.1', repos = 'http://cran.us.r-project.org')"

RUN installGithub.r \
jhudsl/ottrpal \
jhudsl/cow
ottrproject/ottrpal

# Set final workdir for commands
WORKDIR /home/rstudio
Expand Down
3 changes: 1 addition & 2 deletions bioconductor/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ RUN install2.r rlang \
RUN Rscript -e "devtools::install_version('gitcreds', version = '0.1.1', repos = 'http://cran.us.r-project.org')"

RUN installGithub.r \
jhudsl/ottrpal \
jhudsl/cow
ottrproject/ottrpal

# Set final workdir for commands
WORKDIR /home/rstudio
Expand Down