Update file reading for content modification #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Change file reading from doc_path to dest_file before processing to attempt to fix error identified while testing this branch
While testing the changes in this branch, I encountered a new issue with the readLines function. Comparing to the original function, I see a different variable was used.
How I tested this branch:
-- used this branch specifically for ottrpal within the base_ottr dockerfile, building it and pushing it to dockerhub with the testBC tag.
-- Used that image on a few repos and called ottrpal borrow_chapter to test rendering/borrowing a chapter
Error I observed:
-- the error acted like the file didn't exist. But that seems to be because it was looking for a local file which indeed did not exist.
How this should fix it:
-- updating it to look at the full path, not a local path, trying to mirror the original code (https://github.com/jhudsl/cow/blob/be112c8bb9c6ddb9c3b5668a7dd2faa1042281e9/R/borrow_chapter.R#L108)