-
Notifications
You must be signed in to change notification settings - Fork 0
update docs for borrow_chapter and include_slide #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updating some borrow_chapter info
updating the formatting requirements for include_slide
OTTR Check ResultsSummary
🎉 All checks passed!Last Updated: 2025-10-30-17:32:26 |
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2025-10-30 with changes from the latest commit 10643e4 |
carriewright11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I asked Kate to check some other cases
Co-authored-by: Carrie Wright <23014755+carriewright11@users.noreply.github.com>
Co-authored-by: Carrie Wright <23014755+carriewright11@users.noreply.github.com>
@carriewright11 what do you think of the suggested changes I made since the two test cases worked? |
carriewright11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions to try to simplify the explanation.
|
It won't let me reply directly to this: #23 (comment) I still think it'd be good to show both of these, just maybe moving this paragraph underneath the note in the further details section? |
Note that I added your examples.. maybe it isn't showing that? |
they should be right before the click to expand section... or maybe I don't know what you mean |
Given the weird rendering behavior we observed recently (related: jhudsl/AnVIL_Template#268, jhudsl/AnVIL_Book_Getting_Started#178, ottrproject/ottrpal#15), putting in a PR to update the docs to describe formatting requirements for
include_slide(). Made the update in two places (one describing include_slide and the other in faqs/error descriptions.)Also updated borrow chapter with more up to date info