Skip to content

Conversation

@kweav
Copy link
Contributor

@kweav kweav commented Sep 17, 2025

Given the weird rendering behavior we observed recently (related: jhudsl/AnVIL_Template#268, jhudsl/AnVIL_Book_Getting_Started#178, ottrproject/ottrpal#15), putting in a PR to update the docs to describe formatting requirements for include_slide(). Made the update in two places (one describing include_slide and the other in faqs/error descriptions.)

Also updated borrow chapter with more up to date info

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

OTTR Check Results

Summary

  • Spelling check: ✅ PASSED (0 errors found, threshold: 0)
  • URL check: ✅ PASSED (0 errors found, threshold: 0)

🎉 All checks passed!

Last Updated: 2025-10-30-17:32:26

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2025-10-30 with changes from the latest commit 10643e4

Copy link
Contributor

@carriewright11 carriewright11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I asked Kate to check some other cases

kweav and others added 2 commits September 25, 2025 15:47
Co-authored-by: Carrie Wright <23014755+carriewright11@users.noreply.github.com>
Co-authored-by: Carrie Wright <23014755+carriewright11@users.noreply.github.com>
@kweav
Copy link
Contributor Author

kweav commented Sep 25, 2025

Looks good! I asked Kate to check some other cases

@carriewright11 what do you think of the suggested changes I made since the two test cases worked?

Copy link
Contributor

@carriewright11 carriewright11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions to try to simplify the explanation.

@kweav
Copy link
Contributor Author

kweav commented Sep 25, 2025

It won't let me reply directly to this: #23 (comment)

I still think it'd be good to show both of these, just maybe moving this paragraph underneath the note in the further details section?

@carriewright11
Copy link
Contributor

It won't let me reply directly to this: #23 (comment)

I still think it'd be good to show both of these, just maybe moving this paragraph underneath the note in the further details section?

Note that I added your examples.. maybe it isn't showing that?

@carriewright11
Copy link
Contributor

carriewright11 commented Sep 25, 2025

It won't let me reply directly to this: #23 (comment)
I still think it'd be good to show both of these, just maybe moving this paragraph underneath the note in the further details section?

Note that I added your examples.. maybe it isn't showing that?

they should be right before the click to expand section... or maybe I don't know what you mean

@carriewright11 carriewright11 merged commit f89e349 into main Oct 30, 2025
7 checks passed
@kweav kweav deleted the kweav-updateDocsBCIS branch October 30, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants