AO3-6730 Bump rexml from 3.2.6 to 3.2.8 #4810
reviewdog [rubocop] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (11173)
Capfile|1 col 6| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Capfile|2 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Capfile|4 col 6| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Capfile|4 col 81| Final newline missing.
Gemfile|1 col 8| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|5 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|5 col 18| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|7 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|14 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|14 col 29| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|15 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|16 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|22 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|27 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|32 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|33 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|34 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|34 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|39 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|39 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|40 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|40 col 21| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|41 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|43 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|44 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|45 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|45 col 17| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|46 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|46 col 17| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|47 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|48 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|48 col 17| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|50 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|50 col 15| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|51 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|52 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|53 col 1| Missing space after #
.
Gemfile|56 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|62 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|65 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|66 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|66 col 19| Unnecessary spacing detected.
Gemfile|67 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|74 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|79 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|79 col 21| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|81 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|92 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|92 col 28| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|96 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|96 col 23| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|97 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|100 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|100 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|102 col 1| Missing space after #
.
Gemfile|103 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|103 col 41| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|106 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|107 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|107 col 16| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|110 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|113 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|114 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|115 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|115 col 13| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|127 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|128 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|131 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|133 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|134 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|135 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|135 col 16| Unnecessary spacing detected.
Gemfile|140 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|141 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|145 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|145 col 21| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|150 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|151 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|152 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|153 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|155 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|160 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|161 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|161 col 36| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|161 col 46| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|172 col 7| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|172 col 17| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|178 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|178 col 35| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|179 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|182 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|182 col 16| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|184 col 5| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile|184 col 12| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Rakefile|4 col 14| Use expand_path('config/application', __dir__)
instead of expand_path('../config/application', __FILE__)
.
Rakefile|4 col 26| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Rakefile|5 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Rakefile|6 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Rakefile|8 col 1| include
is used at the top level. Use inside class
or module
.
app/controllers/abuse_reports_controller.rb|20 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_invitations_controller.rb|2 col 1| Extra empty line detected at class body beginning.
app/controllers/admin/admin_invitations_controller.rb|10 col 25| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|10 col 37| Prefer setting a translation in the appropriate en.yml
locale file instead of using default
app/controllers/admin/admin_invitations_controller.rb|11 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|13 col 26| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|13 col 34| Prefer setting a translation in the appropriate en.yml
locale file instead of using default
app/controllers/admin/admin_invitations_controller.rb|16 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|34 col 24| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|34 col 43| Prefer setting a translation in the appropriate en.yml
locale file instead of using default
app/controllers/admin/admin_invitations_controller.rb|34 col 52| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/admin_invitations_controller.rb|39 col 5| Use if invitation_params[:user_name].present?
instead of unless invitation_params[:user_name].blank?
.
app/controllers/admin/admin_invitations_controller.rb|44 col 8| Use invitation_params[:token].present?
instead of !invitation_params[:token].blank?
.
app/controllers/admin/admin_invitations_controller.rb|60 col 7| Align the arguments of a method call if they span more than one line.
app/controllers/admin/admin_users_controller.rb|6 col 30| Space missing to the left of {.
app/controllers/admin/admin_users_controller.rb|22 col 19| %w
-literals should be delimited by [
and ]
.
app/controllers/admin/admin_users_controller.rb|25 col 76| Do not use Time.now
without zone. Use one of Time.zone.now
, Time.current
, Time.now.in_time_zone
, Time.now.utc
, Time.now.getlocal
, Time.now.xmlschema
, Time.now.iso8601
, Time.now.jisx0301
, Time.now.rfc3339
, Time.now.httpdate
, Time.now.to_i
, Time.now.to_f
instead.
app/controllers/admin/admin_users_controller.rb|25 col 89| Prefer single-quoted strings inside interpolations.
app/controllers/admin/admin_users_controller.rb|26 col 30| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|62 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|64 col 23| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|80 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|88 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|95 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|125 col 5| Use a guard clause (return if @user && @user.banned?
) instead of wrapping the code inside a conditional expression.
app/controllers/admin/admin_users_controller.rb|125 col 12| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
app/controllers/admin/admin_users_controller.rb|126 col 23| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|148 col 22| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|160 col 27| Useless assignment to variable - options
.
app/controllers/admin/admin_users_controller.rb|161 col 22| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|171 col 29| Space inside parentheses detected.
app/controllers/admin/admin_users_controller.rb|171 col 30| Useless assignment to variable - options
.
app/controllers/admin/admin_users_controller.rb|172 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|173 col 7| Move redirect_to action: :show
out of the conditional.
app/controllers/admin/admin_users_controller.rb|175 col 23| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/admin_users_controller.rb|176 col 7| Move redirect_to action: :show
out of the conditional.
app/controllers/admin/api_controller.rb|6 col 31| Prefer string interpolation to string concatenation.
app/controllers/admin/api_controller.rb|26 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/api_controller.rb|40 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/api_controller.rb|62 col 5| Use a guard clause (return unless params[:cancel_button]
) instead of wrapping the code inside a conditional expression.
app/controllers/admin/api_controller.rb|62 col 5| Favor modifier if
usage when having a single-line body. Another good alternative is the usage of control flow &&
/||
.
app/controllers/admin/banners_controller.rb|2 col 1| Extra empty line detected at class body beginning.
app/controllers/admin/banners_controller.rb|32 col 26| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|32 col 29| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|34 col 26| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|34 col 29| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|38 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|47 col 22| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|49 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|49 col 27| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|54 col 26| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|54 col 29| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|56 col 26| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|56 col 29| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|72 col 22| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/banners_controller.rb|72 col 25| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/banners_controller.rb|81 col 1| Extra empty line detected at class body end.
app/controllers/admin/blacklisted_emails_controller.rb|2 col 1| Extra empty line detected at class body beginning.
app/controllers/admin/blacklisted_emails_controller.rb|7 col 80| Prefer string interpolation to string concatenation.
app/controllers/admin/blacklisted_emails_controller.rb|7 col 80| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/blacklisted_emails_controller.rb|7 col 103| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/blacklisted_emails_controller.rb|18 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/blacklisted_emails_controller.rb|29 col 22| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/sessions_controller.rb|5 col 5| destroy
is not explicitly defined on the class.
app/controllers/admin/skins_controller.rb|2 col 1| Extra empty line detected at class body beginning.
app/controllers/admin/skins_controller.rb|23 col 5| %w
-literals should be delimited by [
and ]
.
app/controllers/admin/skins_controller.rb|24 col 93| Space between { and | missing.
app/controllers/admin/skins_controller.rb|24 col 93| Pass &:to_i
as an argument to map
instead of a block.
app/controllers/admin/skins_controller.rb|24 col 106| Space missing inside }.
app/controllers/admin/skins_controller.rb|25 col 99| Space between { and | missing.
app/controllers/admin/skins_controller.rb|25 col 99| Pass &:to_i
as an argument to map
instead of a block.
app/controllers/admin/skins_controller.rb|25 col 112| Space missing inside }.
app/controllers/admin/skins_controller.rb|36 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|39 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|43 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|47 col 69| Prefer to_s
over string interpolation.
app/controllers/admin/skins_controller.rb|47 col 140| Prefer to_s
over string interpolation.
app/controllers/admin/skins_controller.rb|63 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|66 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|69 col 11| Add empty line after guard clause.
app/controllers/admin/skins_controller.rb|76 col 23| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/skins_controller.rb|76 col 107| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin/skins_controller.rb|88 col 29| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/skins_controller.rb|90 col 27| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/skins_controller.rb|97 col 1| Extra empty line detected at class body end.
app/controllers/admin/user_creations_controller.rb|5 col 7| Do not prefix reader method names with get_
.
app/controllers/admin/user_creations_controller.rb|6 col 5| Add empty line after guard clause.
app/controllers/admin/user_creations_controller.rb|6 col 106| %w
-literals should be delimited by [
and ]
.
app/controllers/admin/user_creations_controller.rb|12 col 5| Use a guard clause (return if @creation_class && @creation_class == Work
) instead of wrapping the code inside a conditional expression.
app/controllers/admin/user_creations_controller.rb|13 col 23| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/user_creations_controller.rb|25 col 22| Avoid multi-line ternary operators, use if
or unless
instead.
app/controllers/admin/user_creations_controller.rb|26 col 25| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/user_creations_controller.rb|27 col 25| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/user_creations_controller.rb|37 col 14| Prefer string interpolation to string concatenation.
app/controllers/admin/user_creations_controller.rb|42 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/user_creations_controller.rb|46 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin/user_creations_controller.rb|55 col 22| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin_posts_controller.rb|2 col 1| Extra empty line detected at class body beginning.
app/controllers/admin_posts_controller.rb|10 col 7| Favor modifier if
usage when having a single-line body. Another good alternative is the usage of control flow &&
/||
.
app/controllers/admin_posts_controller.rb|22 col 39| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|29 col 5| Favor modifier unless
usage when having a single-line body. Another good alternative is the usage of control flow &&
/||
.
app/controllers/admin_posts_controller.rb|31 col 5| Add empty line after guard clause.
app/controllers/admin_posts_controller.rb|32 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|33 col 46| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|33 col 71| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|34 col 42| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|34 col 66| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/admin_posts_controller.rb|60 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/admin_posts_controller.rb|72 col 24| Prefer Rails built-in t
helper over ts
: the latter is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
app/controllers/api/v2/base_controller.rb|32 col 14| Use import_items.blank?
instead of import_items.nil? || import_items.empty?
.
app/controllers/api/v2/bookmarks_controller.rb|65 col 29| Use 2 (not 24) spaces for indenting an expression in an assignment spanning multiple lines.
app/controllers/api/v2/bookmarks_controller.rb|66 col 29| Use 2 (not 24) spaces for indenting an expression in an assignment spanning multiple lines.
app/controllers/api/v2/bookmarks_controller.rb|98 col 1| Extra empty line detected at begin
body beginning.
app/controllers/api/v2/bookmarks_controller.rb|116 col 34| Wrap expressions with varying precedence with parentheses to avoid ambiguity.
app/controllers/api/v2/bookmarks_controller.rb|116 col 34| Prefer string interpolation to string concatenation.
app/controllers/api/v2/bookmarks_controller.rb|119 col 34| Wrap expressions with varying precedence with parentheses to avoid ambiguity.
app/controllers/api/v2/bookmarks_controller.rb|122 col 31| Use e
instead of exception
.
app/controllers/api/v2/bookmarks_controller.rb|168 col 5| Favor modifier if
usage when having a single-line body. Another good alternative is the usage of control flow &&
/||
.
app/controllers/api/v2/bookmarks_controller.rb|172 col 5| Favor modifier if
usage when having a single-line body. Another good alternative is the usage of control flow &&
/||
.
app/controllers/api/v2/bookmarks_controller.rb|189 col 16| Use params[:private].presence || false
instead of params[:private].blank? ? false : params[:private]
.
app/controllers/api/v2/bookmarks_controller.rb|190 col 12| Use params[:recommendation].presence || false
instead of params[:recommendation].blank? ? false : params[:recommendation]
.
app/controllers/api/v2/bookmarks_controller.rb|210 col 55| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/api/v2/works_controller.rb|7 col 27| Prefer pluck(:original_urls)
over map { |w| w[:original_urls] }
.
app/controllers/api/v2/works_controller.rb|7 col 56| Put method call on a separate line if chained to a single line block.
app/controllers/api/v2/works_controller.rb|41 col 72| Prefer pluck(:work)
over map { |r| r[:work] }
.
app/controllers/api/v2/works_controller.rb|71 col 8| Use urls.blank?
instead of urls.nil? || urls.empty?
.
app/controllers/api/v2/works_controller.rb|73 col 17| Wrap expressions with varying precedence with parentheses to avoid ambiguity.
app/controllers/api/v2/works_controller.rb|73 col 64| Use \
instead of +
or <<
to concatenate those strings.
app/controllers/api/v2/works_controller.rb|90 col 19| Use instance_of?(String)
instead of comparing classes.
app/controllers/api/v2/works_controller.rb|118 col 20| Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.
app/controllers/api/v2/works_controller.rb|132 col 19| Prefer string interpolation to string concatenation.
app/controllers/api/v2/works_controller.rb|134 col 19| Prefer string interpolation to string concatenation.
app/controllers/api/v2/works_controller.rb|162 col 7| Avoid rescuing without specifying an error class.
app/controllers/api/v2/works_controller.rb|162 col 17| Use e
instead of exception
.
app/controllers/api/v2/works_controller.rb|187 col 90| Put method call on a separate line if chained to a single line block.
app/controllers/api/v2/works_controller.rb|202 col 29| Use work_params[:post_without_preview].presence || true
instead of work_params[:post_without_preview].blank? ? true : work_params[:post_without_preview]
.
app/controllers/application_controller.rb|24 col 17| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/application_controller.rb|60 col 5| Convert if-elsif
to case-when
.
app/controllers/application_controller.rb|64 col 66| Unnecessary spacing detected.
app/controllers/application_controller.rb|117 col 5| Use a guard clause (return unless logged_in? && cookies[:user_credentials].nil? && controller_name != "sessions"
) instead of wrapping the code inside a conditional expression.
app/controllers/application_controller.rb|120 col 19| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/application_controller.rb|136 col 1| Indent access modifiers like protected
.
app/controllers/application_controller.rb|151 col 1| Tab detected in indentation.
app/controllers/application_controller.rb|151 col 3| Use 2 (not 1) spaces for indentation.
app/controllers/application_controller.rb|153 col 1| Tab detected in indentation.
app/controllers/application_controller.rb|154 col 1| Tab detected in indentation.
app/controllers/application_controller.rb|155 col 1| Tab detected in indentation.
app/controllers/application_controller.rb|156 col 1| Tab detected in indentation.
app/controllers/application_controller.rb|156 col 4| Redundant return
detected.
app/controllers/application_controller.rb|159 col 1| Indent access modifiers like public
.