Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to "Remind to Vote" Button if email is unavailable #315

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

hochiw
Copy link
Contributor

@hochiw hochiw commented Jul 23, 2022

  • Refactored tooltip to maintain a self-contained popper state
  • Added email validator for security contact checking
  • Removed the logic to hide "Remind to vote" button when no email is provided and instead disable the button

Screenshot

Desktop Mobile
Screenshot 2022-07-23 at 2 52 22 PM Screenshot 2022-07-23 at 2 55 10 PM

refs #74

@hochiw hochiw requested a review from elise-ng July 23, 2022 06:58
Copy link
Contributor

@elise-ng elise-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to give hint on how to add email for operators (add security contact email in validator info)

currently as a operator i dont see how to add contact info even if i want to

@hochiw
Copy link
Contributor Author

hochiw commented Jul 25, 2022

we might need to give hint on how to add email for operators (add security contact email in validator info)

currently as a operator i dont see how to add contact info even if i want to

if they know how to create validator I think they probably know how to add that :sosad: but that would be a nice add-on?

@mitchellchou opinion?

@mitchellchou
Copy link

I think ok not to have the hint, our target users should be normal users, the hint may be too complex to put on our site (validators should know where to ask the questions)

@hochiw hochiw merged commit cf6bdd1 into oursky:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants