Attach GA tag to index html #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is awkward cos ViteRadar happens during build time so it burns the GA ID into the index.html when it gets generated. |
hochiw
force-pushed
the
349-ga
branch
2 times, most recently
from
d566c14 to
69cee77
Compare
|
@chihimng updated :adore2x: tested by confirming there are analytics request sent every time I click a page |
elise-ng
suggested changes
Aug 2, 2022
| ReactGA.pageview(location.pathname + location.search); | ||
| }, [location, isInitialized]); | ||
|
|
||
| useEffectOnce( |
There was a problem hiding this comment.
Let's use useEffect with empty dep array if we are not waiting for first occurrence of an condition
| useEffectOnce( | ||
| () => { | ||
| if (id) { | ||
| ReactGA.initialize(id); |
There was a problem hiding this comment.
We might want to put this in a provider, so we can add tracking for user actions other than page view e.g. vote, reaction, post comment in the future
|
@chihimng added wallet analytics :adore2x: |
|
please also see if we can track transaction type & set/unset reaction? |
elise-ng
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #349