Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ghost" duplicates when sorting #191

Closed

Conversation

RobertoNegro
Copy link

Fixes issues #184 and #189 .

The key attribute should identify the row indifferently from its position.

@davidldear
Copy link

Would love to get this merged so we can make this better for our users.

@dannyklaassen
Copy link

Please add this fix. It is already open for a month now.

@Tarpsvo Tarpsvo closed this Nov 27, 2023
@Tarpsvo
Copy link
Collaborator

Tarpsvo commented Nov 27, 2023

Heya! Thanks a ton for the PR! I added a fallback as well (${resourceName}-items-${resource.id?.value || index}) just in case. Maybe it might be necessary to use a composite instead, but I hope this will suffice. Will do some testing soon.

The new release is tagged 3.4.7.

Thanks again and good luck to you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants