[nit] Make protocol errors more typed and idiomatic. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeonzip is attempting to deploy a commit to the facehh's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
This pr would also fit in with the eventual pr for issue #108 by replacing e.g |
Member
|
i believe this PR should also fix the breaking changes in gurtlib-reliant subprojects |
Author
I'll do that then, but to also ensure other 3rd party libraries gets a heads up, we could also keep the construction methods but mark them as deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small DX/QoL cleanup; make GURT protocol lib's errors (GurtError) more directly typed as more idiomatic in rust style and remove redundant methods for GurtError.