Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: re-add auto-add for PRs with a different target #1189

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Jan 16, 2025

This PR re-enables the auto-add-to-project for PRs but uses a different event (it was previously removed in #1011). Instead of using pull_request, it relies on pull_request_target https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target. The pull_request_target allows running the GA on pull request base branch context and is recommended to use only if the underlying actions are NOT using / running any code from PR. The docs suggest using this if one needs to add labels or comments to PR.

@DawoudSheraz DawoudSheraz requested a review from regisb January 16, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants