feat: support for mongodb SSL+auth source/mech+replica set #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
regisb/mongodb-ssl
branch
2 times, most recently
from
d09f7c9 to
ee1475e
Compare
regisb
force-pushed
the
regisb/mongodb-ssl
branch
from
ee1475e to
1cbe95b
Compare
regisb
changed the title
regisb
force-pushed
the
regisb/mongodb-ssl
branch
from
1cbe95b to
619e7b8
Compare
keithgg
reviewed
Nov 28, 2022
This change builds upon a previously proposed PR: #437 There was another long conversation about this topic here: overhangio/tutor-forum#10 (comment) We could have supported the MongoDB auth/replica set/ssl parameters as part of the MongoDB host URI, but then this URI is not supported in the forum plugin, which uses an old version of the mongoid client. We were hoping that the client would have been upgraded by now, but it's not been upgraded for a long time. The changes introduced here are 100% backward-compatible. The forum plugin will have to be updated to take into account the new parameters.
regisb
force-pushed
the
regisb/mongodb-ssl
branch
from
619e7b8 to
6f917ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds upon a previously proposed PR:
#437
There was another long conversation about this topic here:
overhangio/tutor-forum#10 (comment)
We could have supported the MongoDB auth/replica set/ssl parameters as part of
the MongoDB host URI, but then this URI is not supported in the forum plugin,
which uses an old version of the mongoid client. We were hoping that the client
would have been upgraded by now, but it's not been upgraded for a long time.
The changes introduced here are 100% backward-compatible. The forum plugin will
have to be updated to take into account the new parameters.