fix: race condition could cause mkdirs() to fail with "file exists"

[0x29a]

Exactly the same issue as #649, but with Studio:

*** Operational MODE: preforking ***
spawned uWSGI worker 1 (pid: 7, cores: 1)
spawned uWSGI worker 2 (pid: 9, cores: 1)
Traceback (most recent call last):
  File "cms/wsgi.py", line 21, in <module>
    import cms.startup as startup  # lint-amnesty, pylint: disable=wrong-import-position
  File "/openedx/edx-platform/./cms/startup.py", line 10, in <module>
    settings.INSTALLED_APPS  # pylint: disable=pointless-statement
  File "/openedx/venv/lib/python3.8/site-packages/django/conf/__init__.py", line 82, in __getattr__
    self._setup(name)
  File "/openedx/venv/lib/python3.8/site-packages/django/conf/__init__.py", line 69, in _setup
    self._wrapped = Settings(settings_module)
  File "/openedx/venv/lib/python3.8/site-packages/django/conf/__init__.py", line 170, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/opt/pyenv/versions/3.8.12/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/openedx/edx-platform/./cms/envs/tutor/production.py", line 260, in <module>
    os.makedirs(folder)
  File "/opt/pyenv/versions/3.8.12/lib/python3.8/os.py", line 223, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/openedx/data/logs'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***

Also, this doesn't happen when OPENEDX_CMS_UWSGI_WORKERS is set to 1.

[kaustavb12]

@0x29a Can you please add a changelog entry too.

[kaustavb12]

👍

@0x29a I tested this change in a sandbox and it solved the issue. This is approved from my end subject to the resolution of my comment above.

• I tested this: Deployed and tested in sandbox
• I read through the code

[0x29a]

Thanks for the review, @kaustavb12. I added the entry.

cc @regisb

[regisb]

As indicated at the top of the changelog file, please don't add entries here. Instead, create new changelog entries with make changelog-entry. See: https://docs.tutor.overhang.io/tutor.html#contributing

[regisb]

I'll merge as-is and fix the changelog manually.

[0x29a]

Thanks, @regisb and sorry, I didn't get to fixing this. I'll keep this in mind.