Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add INFO_EMAIL variable #885

Closed
wants to merge 1 commit into from
Closed

Conversation

misilot
Copy link

@misilot misilot commented Aug 2, 2023

Add a default value for the INFO_EMAIL which is used by the Authn frontend app.

https://github.com/openedx/frontend-app-authn/blob/a723058bc114a8c70b463e2aa15fd11dea1e1705/README.rst?plain=1#L91-L93

Add a default value for the INFO_EMAIL which is used by the Authn frontend app.
@regisb
Copy link
Contributor

regisb commented Aug 3, 2023

What's the impact of this change? Can you please screenshots before/after?

@misilot
Copy link
Author

misilot commented Aug 3, 2023

What it should do is add the email address at the bottom of the Authn MFE see where the sentence trails off. Just setting the value and restarting tutor doesn't seem to make it work, so I am rebuilding the openedx image.

image

Example of it missing: https://apps.demo.openedx.overhang.io/authn/reset?next=%2F (just put in example@example.com)

The url for contact tech support in the alert box is configured by PASSWORD_RESET_SUPPORT_LINK which is also missing, so trying to get that working as well.

@regisb
Copy link
Contributor

regisb commented Aug 3, 2023

I think that the value should be added to the MFE_CONFIG setting: https://github.com/overhangio/tutor-mfe/blob/8522ab6adf149d27e6aeaed567795857af1c0647/tutormfe/patches/openedx-lms-production-settings#L3C1-L3C11

If you're not sure whether your changes work, please mark your PR as draft. Otherwise I'll assume you have already tested and verified your changes.

@misilot misilot changed the title Add INFO_EMAIL variable Draft: Add INFO_EMAIL variable Aug 3, 2023
@misilot
Copy link
Author

misilot commented Aug 3, 2023

I'm trying that as well. For changes like that does the mfe image need to be rebuilt for it to to be recoginzied? As, I am having trouble building mfe on Olive.

@misilot misilot closed this Aug 3, 2023
@misilot
Copy link
Author

misilot commented Aug 3, 2023

They need to be applied to the MFE it looks like.

@regisb
Copy link
Contributor

regisb commented Aug 9, 2023

No, you don't need to rebuild the MFE image after a config change since Palm. It was the case in Olive, but it's no longer necessary now that we have runtime config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants