Add robust db check for checkpoint sync #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-anderson
reviewed
Sep 6, 2024
sb-anderson
approved these changes
Sep 6, 2024
|
FYI) When this change is applied, if the state at the checkpoint is deleted, the sync will start from the new checkpoint received from the origin. Based on my understanding, there are two possible scenarios:
These are potential scenarios, but IMO, they will not occur frequently. |
syjn99
pushed a commit
that referenced
this pull request
Sep 24, 2024
* imported superblock-dev/kairos * github action added * github token setting * kairos dependency setting done & dolphin/under config added * fixed build problem for tools and changed linter setting * added deneb fork version to dolphin to pass fuzz test * added deneb fork version to dolphin to pass fuzz test2 * fixed param tests * fixed validator/accounts test * removed prysm web UI * update linter action * update linter config * Add bailout at beacon state * Add bailout to block types * Add bailout config * Add bailout logic * Update/build settings (#1) * imported superblock-dev/kairos * github action added * github token setting * kairos dependency setting done & dolphin/under config added * fixed build problem for tools and changed linter setting * added deneb fork version to dolphin to pass fuzz test * added deneb fork version to dolphin to pass fuzz test2 * fixed param tests * fixed validator/accounts test * removed prysm web UI * update linter action * update linter config * Add bailout logic * Fix error * Add bailout to api struct * Add bailout rpc * Fix lint * Add bailout to blindblock * Fix test * Fix build error * Fix test and error * Add bailout to experimental state * Fix sharedFieldRefCount * Fix test * Fix FieldRefCount * Apply anderson's comments Co-authored-by: Anderson <97861652+sb-anderson@users.noreply.github.com> * Apply jay's comments * Apply jays comments --------- Co-authored-by: Jay <jay@superblock.xyz> Co-authored-by: Jay <gts2030@snu.ac.kr> Co-authored-by: Anderson <97861652+sb-anderson@users.noreply.github.com>
syjn99
added a commit
that referenced
this pull request
Sep 24, 2024
syjn99
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checkpoint sync is enabled, beacon node checks db whether the checkpoint origin block root exists in db. If it exists, it skips checkpoint sync progress(e.g. download finalized data from remote url).
This work adds a robust check for checkpoint sync. By checking if a checkpoint state exists in db, this will remove the chance of failing in init process like: