bug fix - nested restrictions #236
Conversation
|
We should have a test to capture this issue. Since we don't can you add one? |
| @@ -165,6 +167,34 @@ describe('Parse Values - parseFieldValue', () => { | |||
| expect(parseFieldValue(' !@#$%^&* ()_+ ', fieldStringNoRestriction).success).true; | |||
| expect(parseFieldValue(' !@#$%^&* ()_+ ', fieldStringNoRestriction).data).equals('!@#$%^&* ()_+'); | |||
| }); | |||
| it('Successfuly parses strings, with conditional restrictions', () => { | |||
| const value = 'any random string value!!!'; | |||
| const result = parseFieldValue(value, fieldStringConditionalExists); | |||
There was a problem hiding this comment.
testing parsing any string using a Schema Field Definition having if/then/else restrictions
| }); | ||
| it('Successfuly parses strings, with conditional restrictions without then or else', () => { | ||
| const value = 'any random string value!!!'; | ||
| const result = parseFieldValue(value, fieldStringConditionalExistsWithouthThenElse); |
There was a problem hiding this comment.
Testing parsing any string using a Schema Field Definition having anif restriction without then/else. This is not a functional Schema definition however to cover every scenario possible we have to test it.
There was a problem hiding this comment.
Is the expected behaviour that an if without then/else just never applies restrictions?
Should we consider adding validation to lectern dictionaries to require an if to have a then or else (at least one of the two)?
There was a problem hiding this comment.
If not then/else is found in the schema definition the expected behaviour is do not apply the restriction. Based on test resolveFieldRestrictions.spec.ts
There was a problem hiding this comment.
I'm open to add a validation to require at least one between then/else. Although it could be added in a separate PR
|
PR updated. Adding Unit tests to verify this functionality. |
There was a problem hiding this comment.
typo in file name: Withouth
| }); | ||
| it('Successfuly parses strings, with conditional restrictions without then or else', () => { | ||
| const value = 'any random string value!!!'; | ||
| const result = parseFieldValue(value, fieldStringConditionalExistsWithouthThenElse); |
There was a problem hiding this comment.
Is the expected behaviour that an if without then/else just never applies restrictions?
Should we consider adding validation to lectern dictionaries to require an if to have a then or else (at least one of the two)?
PR Changes include:
ParseFieldErrortype on Lectern client package. This type is used in parse functions.