feat(okms): add continent tabs to region picker #20815
Open
+518
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieumousnier
force-pushed
the
feat/MANAGER-19097
branch
from
728bf3b to
400e512
Compare
mathieumousnier
requested review from
rjamet-ovh
and removed request for
a team
tibs245
approved these changes
Dec 4, 2025
rjamet-ovh
reviewed
Dec 4, 2025
| expect(screen.getByTestId('NORTH_AMERICA')).toBeInTheDocument(); | ||
| expect(screen.queryByTestId('ASIA')).not.toBeInTheDocument(); | ||
| expect(screen.queryByTestId('AFRICA')).not.toBeInTheDocument(); | ||
| expect(screen.queryByTestId('OTHERS')).not.toBeInTheDocument(); |
Contributor
There was a problem hiding this comment.
you can create a mocked constant like this
export const continentCodes: Record<ContinentCode, ContinentCode> = {
EUROPE: 'EUROPE',
NORTH_AMERICA: 'NORTH_AMERICA',
ASIA: 'ASIA',
AFRICA: 'AFRICA',
OTHERS: 'OTHERS',
} as const;
that way, you can replace the hardcoded strings on your differents tests with continentCodes.EUROPE
ref: #MANAGER-19097 Signed-off-by: Mathieu Mousnier <mathieu.mousnier.ext@ovhcloud.com>
mathieumousnier
force-pushed
the
feat/MANAGER-19097
branch
from
400e512 to
00d94bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-19097