[FIX] change schema name to aggregate data #1188
Conversation
|
@morrone Did you review this and find it OK? |
It doesn't have my name on it anymore, and looks like a stand-alone commit. That is good. But the commit message doesn't really meet the minimal bar for acceptance. I don't have any comment on the actual code change. |
| @@ -81,7 +81,7 @@ const metric_t metricsDefinitions[] = { | |||
| {.name = "perf_level", .type = LDMS_V_D64, .pf = (funcPtr_t) getPerfLevel}, | |||
| {.name = "power_usage (mW)", .type = LDMS_V_S32, .pf = (funcPtr_t) getPowerUsage}, | |||
| // {.name = "power_cap (mW)", .type = LDMS_V_S32, .pf = (funcPtr_t) getPowerCap}, // no longer supported | |||
| {.name = "gpu_temp (Celsius)", .type = LDMS_V_D64, .pf = (funcPtr_t) getGpuTemp}, | |||
| {.name = "gpu_temp (Celsius)", .type = LDMS_V_D64, .pf = (funcPtr_t) getGpuTemp} | |||
There was a problem hiding this comment.
@VanshIntel It is not good practice to put the units in the metric name. There is a separate field for that. It is also not good practice to put (, #, etc... in the metric name because this makes subsequent analysis with Python and other tools more difficult as these are special characters.
There was a problem hiding this comment.
@tom95858 I removed the Unit from metric name, Please let me know if any other changes require.
| @@ -81,7 +81,7 @@ const metric_t metricsDefinitions[] = { | |||
| {.name = "perf_level", .type = LDMS_V_D64, .pf = (funcPtr_t) getPerfLevel}, | |||
| {.name = "power_usage (mW)", .type = LDMS_V_S32, .pf = (funcPtr_t) getPowerUsage}, | |||
There was a problem hiding this comment.
@VanshIntel it looks like almost all of these metric names have the unit string in them. What I'm asking is that you please:
- remove the '(<unit-name>)' from all of the metric names
- add the unit string you remove to an entry called .unit="". Don't include the '()' in that string
For example,
. . .
{.name = "power_usage", .unit="mW", .type = LDMS_V_S32, .pf = (funcPtr_t)getPowerUsage},
{.name = "gpu_temp", .unit="Celsius", .type = LDMS_V_D64, .pf = (funcPtr_t) getGpuTemp},
. . .
The other change I'm asking that you make is to change the commit message to something like:
"Modify the schema name and add the set metric unit names"
There was a problem hiding this comment.
@tom95858 Thanks for the pointing the issue, I've made the changes accordingly. Please let me know if there is any other changes require.
There was a problem hiding this comment.
Thanks @VanshIntel. Could you please change the commit message to something like:
Refactor schema and metric names.
The schema name is changed to "gpumetrics"
The metric names have been refactored to move the unit
string from the metric name to the .unit field of the schema
metric data structure.
There was a problem hiding this comment.
@VanshIntel also please squash all of this into a single commit.
There was a problem hiding this comment.
@tom95858 I've merge all the changes into single commit. Please let me know if it require any changes.
There was a problem hiding this comment.
@VanshIntel yes you have, however the commit message could be better, e.g.
Refactor schema and metric names
removing the unit
removing the unit
[FIX] - Schema name and unit names correction
All I'm asking is that you fix the commit message to
Refactor schema and metric names
and remove the extra stuff. I
There was a problem hiding this comment.
@tom95858 Sorry for the confusion. I've just updated the comment. Please let me know if there is any changes require. Thanks
There was a problem hiding this comment.
@tom95858 I've pushed the changes. Please let me know if you require any changes.
There was a problem hiding this comment.
@tom95858 Can you please approve this merge or Please let me know if any changes require.
|
@tom95858 Can you please review this merge or Please let me know if any changes require. |
Refactor schema and metric names correcting metric names change schema name
gpu_metrics_sampler