Fix wrong rail_gn size in rail connect message #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug prevented the passive side of LDMS to accept multiple rail connections from the same source due to wrong `rail_gn` in the connect message. The size of `rail_gn` in the message was incorrectly being 32-bit, too small to receive the actual 64-bit rail_gn, resulting in `msg.rail_gn` being 0 in the network-byte order + bit reduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug prevented the passive side of LDMS to accept multiple rail connections from the same source due to wrong
rail_gnin the connect message. The size ofrail_gnin the message was incorrectly being 32-bit, too small to receive the actual 64-bit rail_gn, resulting inmsg.rail_gnbeing 0 in the network-byte order + bit reduction.