Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ldmsd_plugattr report log messages to the application's default log #1250

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

nichamon
Copy link
Collaborator

@nichamon nichamon commented Aug 8, 2023

The patch is to fix build problems of stand-alone application in the project that uses the library.

The patch is to fix build problems of stand-alone application in the
project that uses the library.
@nichamon
Copy link
Collaborator Author

nichamon commented Aug 8, 2023

@morrone Could you give this a try?

@morrone
Copy link
Collaborator

morrone commented Aug 9, 2023

Yes, it does compile now. Thanks!

@nichamon
Copy link
Collaborator Author

nichamon commented Aug 9, 2023

Yes, it does compile now. Thanks!

@morrone Thanks for trying it out!

@nichamon nichamon requested a review from tom95858 August 9, 2023 15:07
@tom95858 tom95858 merged commit ccc2c31 into ovis-hpc:OVIS-4 Aug 9, 2023
14 checks passed
@tom95858
Copy link
Collaborator

tom95858 commented Aug 9, 2023

@baallan, could you please take a look at a way to remove this library. Otherwise, we have no way to control how log messages from your samplers can be properly controlled with the log_level command.

@baallan
Copy link
Collaborator

baallan commented Aug 10, 2023

I will look into this.

The plugattr library is utilities for processing configuration values (all during the config method). As such, the messages should really be controlled by the debug level at which config-statement processing is being handled, not by the sampler-specific logging level which is appropriate during sample() and the other methods.

I have a patch already for the standalone program references to logging.

@nichamon nichamon deleted the fix-ldmsd_plugattr-log-2 branch October 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants