Fix ldmsd_stream_subscribe intermingled events output #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple threads in `ldmsd_stream_subscribe` can race to handle stream recv events. The recv handler called `msglog()` multiple times to print out the EVENT. This lead to intermingled events in the output. This patch modifies the handler to print the events in single msglog call to avoid the intermingled output.
|
@tom95858 why do you close this one? I think we need this. |
|
We had two versions of this...yes? Or is it a different pull request. I thought you had a different fix. |
|
We have 2 version of this fix. This version is a lot easier to read than the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple threads in
ldmsd_stream_subscribecan race to handle stream recv events. The recv handler calledmsglog()multiple times to print out the EVENT. This lead to intermingled events in the output. This patch modifies the handler to print the events in single msglog call to avoid the intermingled output.