Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 removal multiple scripts #1427

Merged
merged 15 commits into from
Sep 14, 2024

Conversation

jennfshr
Copy link
Collaborator

@jennfshr jennfshr commented Aug 5, 2024

@bschwal this removes python2 from OVIS-4

bash-4.4$ grep -r "/usr/bin/env python2" rpmbuild/BUILD/    
rpmbuild/BUILD/ovis-ldms-4.4.3/ldms/src/sampler/shm/mpi_profiler/wrap/wrap.py:#!/usr/bin/env python2  
rpmbuild/BUILD/ovis-ldms-4.4.3/ldms/src/sampler/filesingle/ldms-sensors-config:#! /usr/bin/env python2  
rpmbuild/BUILD/ovis-ldms-4.4.3/ldms/scripts/ldms-csv-export-sos:#! /usr/bin/env python2  
rpmbuild/BUILD/ovis-ldms-4.4.3/ldms/scripts/ovis-roll-over.py:#!/usr/bin/env python2  
rpmbuild/BUILD/ovis-ldms-4.4.3/ldms/scripts/ldms-csv-anonymize:#! /usr/bin/env python2

I still need to do some testing to ensure I didn't introduce any bad syntax. Evan and I plan on testing this early this week. If you have a chance, please review.

@tom95858
Copy link
Collaborator

@jennfshr did you and Evan get a chance to test this?

@baallan
Copy link
Collaborator

baallan commented Aug 29, 2024

I'm working my way through review and test.
I see in addition to 2->3 porting, there's quite a bit of variable name cleanup and commented debugging statements removal. Most of these changes are improving readability, so i'm fine with it being all in one PR.

@baallan
Copy link
Collaborator

baallan commented Sep 3, 2024

Created jennfshr#2 of suggested changes to this pr.

@jennfshr jennfshr changed the title DRAFT: Python2 removal multiple scripts Python2 removal multiple scripts Sep 6, 2024
@tom95858 tom95858 merged commit 6fa656c into ovis-hpc:OVIS-4 Sep 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants