Fix ldmsd_controller completion without ldmsd connection
#1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick-enoent I cannot assign you as a reviewer .. So here's a review invitation :) |
tom95858
reviewed
Aug 26, 2024
When there is no `ldmsd` connection, `ldmsd_controller` command parameter completion does not work. This patch fixes the issue.
narategithub
force-pushed
the
fix-ldmsd-controller-completion
branch
from
ebc0de1
to
37d4afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no
ldmsdconnection,ldmsd_controllercommand parameter completion does not work. This patch fixes the issue.