-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LDMS Variorum sampler to support Variorum v0.8 #1447
base: OVIS-4
Are you sure you want to change the base?
Conversation
@tpatki Could you also please this squash this PR together into just a small set of clean commits? You will also need to include appropriate autoconf checks since this will now only work with variorum 0.8 or newer. |
@morrone Yes, I will squash into clean commits when we're done testing and when I mark this as ready for review (will be a few weeks until @kshoga1 can test on Mutt.)
Could you please clarify this? We were not checking for a specific version in |
Better than a specific version check is to test for features in the library that the code requires. For instance, are there some unique new function in the new version of the library? You could add a test for that function in the library. LDMS's configure.ac has an AC_LIB_HAVE_LINKFLAGS test for variorum. There is an additional "testcode" field for that macro where you could put a tiny bit of C code that calls a function that is unique to the newer version of the code. https://www.gnu.org/software/gnulib/manual/html_node/Searching-for-Libraries.html |
Work in Progress, not ready for review.
Fixes #1431.
This PR updates the JSON API and the parsing of power data based on Variorum 0.8.
ToDo:
Testing: