[READ ONLY] Ovos Mod #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t cache and do not throw an exception - so that php-di does not break if there is any problem with apcu - instead of having to wrap ContainerBuilder::build() with try...catch block
- there might be multiple definitions files scattered around in a modularized architecture - instead of listing all the files upfront, specify a glob pattern where to look for the files - directories would be scanned and files read lazily, when a definition is actually requested - to avoid performance hit on init
- run preg_replace_callback already during compilation
- compile final function with injected dependencies - only for closure factories for now (as the first step)
- adds possibility to disable features which are not used - useAnnotations(boolean) toggle on autowire() helper to enable/disable reading annotations on specific definitions
- Serving "lazy" dependencies for classes using ServiceSubscriberInterface. - A ServiceSubscriber exposes its dependencies via static getSubscribedServices() method. - A ServiceLocator instance could then be injected into a class via constructor or a property - the instance would be already configured with dependences read from getSubscribedServices(), but the dependences won't be instantiated until first get - that's how "laziness" is introduced - DI\Definition\Reference checks if it's a ServiceLocator entry by comparing its name with DI\Definition\Reference::$serviceLocatorClass - Reference definitions are passed with additional parameter - $requestingName which generally points to name of the class which implements ServiceSubscriberInterface - to resolve ServiceLocator for that class - Suggested as a lightweight alternative for heavyweight proxies from ocramius/proxy-manager
- the method may be used only before a locator instance is created - to avoid ambiguous situations - create method refactored - a locator instance will be returned if already created, only if passed services match, otherwise an exception will be thrown
- resolve and isResolvable will check if getSubscribedServices method exists on given class
+ added the same method_exists check as in ServiceLocatorDefinition
DefinitionGlob
Loosen APCu check for SourceCache
…nitions Optimize compiled string definitions
Optimize compiled factory definitions
AnnotationBasedAutowiring with additional options for performance tweaks
Feature/service locator
Feature/service locator
SourceCache: namespacing cache keys
enable apcu on travis + php 7.3
…mize-string-definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT MERGE THIS PR
This PR has been created only to trigger CI (Continuous Integration) builds.