Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--techs, --exclude-techs 동작 개선 #504

Merged
merged 2 commits into from
Jan 19, 2025
Merged

--techs, --exclude-techs 동작 개선 #504

merged 2 commits into from
Jan 19, 2025

Conversation

ksg97031
Copy link
Member

@hahwul
이것도 시간 괜찮으실 때 리뷰 부탁드립니다~

  1. --techs, --exclude-techs 쉼표 입력 시에도 정상처리
    Fixes: --techs, --exclude-techs options don't seem to handle commas as expected. #502
  2. --techs 에러메시지 추가
crystal run src/noir.cr -- -b ../malll/ --techs asdf  # 등록되지 않은 tech 입력 시

░█▄─░█ ░█▀▀▀█ ▀█▀ ░█▀▀█
░█░█░█ ░█──░█ ░█─ ░█▄▄▀
░█──▀█ ░█▄▄▄█ ▄█▄ ░█─░█ {v0.18.3}

⚑ Detecting technologies to base directory.
✔ Setting 1 techs from command line.
✖︎ asdf is not recognized in the predefined tech list.      <<<< 에러메시지 출력
▲ No technologies detected.
  ➔ If you know the technology, use the -t flag to specify it.
  ➔ Please check tech lists using the --list-techs flag.
  1. exclude-techs 개선 (skip 표시 + analyzer.cr 보다 앞단인 noir.cr에서 처리)
$ crystal run src/noir.cr -- -b ../github_repos/Destiny-Api/ --exclude-techs java_spring  # exclude 설정 시

░█▄─░█ ░█▀▀▀█ ▀█▀ ░█▀▀█
░█░█░█ ░█──░█ ░█─ ░█▄▄▀
░█──▀█ ░█▄▄▄█ ▄█▄ ░█─░█ {v0.18.3}

⚑ Detecting technologies to base directory.
✔ Detected 2 technologies.
  ├── kotlin_spring
  └── java_spring (skip)       <<< skip한다는 내용 출력
⚑ Start code analysis based on the detected technology.
⚑ Initializing analyzers
⚑ Analysis Started
  ➔ Code Analyzer: 1 in use       <<< analyzer에서 스킵 안된 대상만 동작
⚑ Found 23 endpoints
⚑ Optimizing endpoints.
  ➔ Removing duplicated endpoints and params.
  ➔ Adding path parameters by URL.
✔ Finally identified 21 endpoints.
⚑ Scan completed in 0.5437 s.
⚑ Generating Report.
★ Endpoint Results:

@ksg97031 ksg97031 requested a review from hahwul January 18, 2025 17:29
@ksg97031 ksg97031 self-assigned this Jan 18, 2025
@github-actions github-actions bot added 🔎 detector Issue for Detector 🔬 analyzer Issue for Analyzer labels Jan 18, 2025
@hahwul hahwul added this to the v0.19.0 milestone Jan 19, 2025
Copy link
Member

@hahwul hahwul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@hahwul hahwul merged commit 7e6179c into main Jan 19, 2025
7 checks passed
@hahwul hahwul deleted the issue-502 branch January 19, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 analyzer Issue for Analyzer 🔎 detector Issue for Detector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--techs, --exclude-techs options don't seem to handle commas as expected.
2 participants