Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Use expand_config in energy prices mdim #4004

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Feb 19, 2025

I've started this with the intention of merging generate_views_for_dimensions with expand_config. The plan was to add information about dimensions to tb[col].m.additional_info and then let expand_config do its magic.

It turned out that getting dimensions from a flattened indicator is harder than expected. Putting a band-aid on it in the export step didn't feel right. It'd only work if we were setting this information when flattening (i.e. in the garden steps).

Parking this until we get more experience with mdims.

@Marigold Marigold marked this pull request as ready for review February 19, 2025 20:55
@owidbot
Copy link
Contributor

owidbot commented Feb 19, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-config-energy-prices

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-02-19 20:57:40 UTC
Execution time: 16.64 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants