use OCA.Search to customize results #57
Conversation
|
makes sense 👍 |
|
@butonic ouch - what happened to the unit tests? |
|
hmm - requires rebase ... |
butonic
force-pushed
the
fix_results_for_full_page
branch
from
21db916
to
8eeb587
Compare
| @@ -47,7 +48,7 @@ public function __construct(QueryHit $hit) { | |||
| ); | |||
| $this->permissions = $this->getPermissions($this->path); | |||
| $this->modified = (int)$hit->mtime; | |||
| $this->mime_type = $hit->mimetype; | |||
| $this->mime = $hit->mimetype; | |||
There was a problem hiding this comment.
@butonic a parent class has mime_type property here: https://github.com/owncloud/core/blob/master/lib/private/search/result/file.php#L62
| @@ -15,6 +15,7 @@ | |||
| // --- always add js & css ----------------------------------------------- | |||
|
|
|||
| OCP\Util::addScript('search_lucene', 'checker'); | |||
| OCP\Util::addScript('search_lucene', 'search'); | |||
There was a problem hiding this comment.
@butonic this file is missing in js folder
|
@VicDeo thx, added it |
VicDeo
force-pushed
the
fix_results_for_full_page
branch
from
ee9ffc4
to
9e5cb4d
Compare
VicDeo
force-pushed
the
fix_results_for_full_page
branch
from
9e5cb4d
to
99cb0ac
Compare
VicDeo
force-pushed
the
fix_results_for_full_page
branch
from
99cb0ac
to
fd670b8
Compare
|
@VicDeo good to go? |
|
@butonic TBH, I can't make search results to appear for master and this branch. |
|
@butonic ok, got it. missing etag causes js error while quireing a preview and results are not rendered at all. Needs to be fixed in this PR Additionally #searchresults has margin-top:-250px. when there are only results for 'other places' (e.g. lucene) these results are pushed too high to top (and become invisible). This one is tracked at owncloud/core#16878 |
VicDeo
force-pushed
the
fix_results_for_full_page
branch
2 times, most recently
from
f0449b3
to
c4fb111
Compare
|
I don't think it will make it into 8.1 -> moving to 9.0 cc @karlitschek @cmonteroluque |
|
search lucene is a pure appstore app now - we need to push an updated version for 8.2 |
|
in addition: taking care about comments would be great as well |
|
Not yet reviewed -> 9.1 |
|
moving to 9.1.1 |
|
enhancement/new API -> 9.2 (let me know if you think otherwise) |
|
move to backlog or 10.0.1 ? (and find reviewers) |
|
backlog |
fixes #55 as the full text results were lacking the code to properly integrate with the full page results. code got lost somewhere ... cc @DeepDiver1975 @jnfrmarks