[feature/mem-optimizations] Optimize memory usage #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
felix-schwarz
force-pushed
the
feature/mem-optimizations
branch
from
8d01f6e to
e57ad35
Compare
hosy
requested changes
Jan 21, 2025
- OCBookmark: - add `metaDataStorageURL` property for transitioning data from internal/memory to external/disk storage - if `metaDataStorageURL` is set, externalize avatar/avatarData and load it only on demand for as short as possible - keep track of whether an avatar has been stored via avatarDataURL - OCBookmarkManager - add code to transition bookmarks from internal to external storage - add code to store changed and transitioned data to external storage
- effectively disable caching in minimum memory configuration for OCCore's thumbnail cache and OCResourceManager's OCResource cache
…ed - and instead implement what was intended: prevent caching altogether
felix-schwarz
force-pushed
the
feature/mem-optimizations
branch
from
a6aff7a to
7bfe325
Compare
… the OCResource* subsystem existed)
…om OCClassSettings sources
|
@hosy I had to merge this PR in order to resolve merge conflicts in owncloud/ios-app#1430 (which required merging with ios-app/master, which - already having merged the ios-app portion of this PR - in turn requires the SDK changes in this PR). The one finding that turned up during CR was addressed - if there's more to address, please let me know. |
felix-schwarz
added a commit
that referenced
this pull request
Jan 30, 2025
… to avoid libSwiftCore.dylib overhead/permanent memory allocation, saving up to several MBs (addition to #121) - Localizable.xcstrings: mark stale strings as manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the memory consumption of the SDK.
Opportunities
OCBookmarks which are kept in memoryTypes of changes