Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): report errors for missing class method impls #8082

Open
wants to merge 1 commit into
base: c/12-23-fix_parser_report_syntax_errors_for_missing_constructor_implementations
Choose a base branch
from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 23, 2024

No description provided.

Copy link
Contributor Author

camc314 commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 23, 2024 21:58
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8082 will not alter performance

Comparing c/12-23-fix_semantic_report_errors_for_missing_class_method_impls (d199db3) with c/12-23-fix_parser_report_syntax_errors_for_missing_constructor_implementations (b9ac5c4)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 marked this pull request as draft December 23, 2024 22:57
@camc314 camc314 force-pushed the c/12-23-fix_semantic_report_errors_for_missing_class_method_impls branch from 5b985c0 to d199db3 Compare December 23, 2024 23:11
@camc314 camc314 marked this pull request as ready for review December 23, 2024 23:11
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 24, 2024
Copy link
Member

Boshen commented Dec 24, 2024

Merge activity

  • Dec 23, 8:35 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 24, 4:24 AM UTC: A user added this pull request to the Graphite merge queue.
  • Dec 24, 4:24 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #8081.
  • Dec 24, 4:24 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #8081.

@Boshen
Copy link
Member

Boshen commented Dec 24, 2024

I'll add some follow up PRs.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants