Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add vitest/no-standalone-expect rule #8986

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

taearls
Copy link
Contributor

@taearls taearls commented Feb 9, 2025

Since this rule and tests already existed under the jest directory, I simply created a directory for no_standalone_expect and migrated the jest rule, jest tests, and vitest tests there.

I didn't need to modify any existing logic for this rule to pass.

I added no-standalone-expect to the sorted set of VITEST_COMPATIBLE_JEST_RULES.

Copy link

graphite-app bot commented Feb 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@taearls taearls changed the title feat(linter): add vitest/no_standalone_expect rule feat(linter): add vitest/no-standalone-expect rule Feb 9, 2025
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 9, 2025
Copy link

codspeed-hq bot commented Feb 9, 2025

CodSpeed Performance Report

Merging #8986 will not alter performance

Comparing taearls:linter/vitest-no-standalone-expect (a9eea7e) with main (f2d28f3)

Summary

✅ 33 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant