Skip to content

feat(minifier): remove unused function expression with name by remove_dead_code #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 10, 2025

I think whether the name exists or not does not affect whether the function expression can be removed or not because the name can only be referenced inside that function.

Copy link
Member Author

sapphi-red commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review February 10, 2025 06:00
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Feb 10, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
…_dead_code (#8996)

I think whether the `name` exists or not does not affect whether the function expression can be removed or not because the name can only be referenced inside that function.
@graphite-app graphite-app bot force-pushed the 02-10-refactor_minifier_extract_symbols_.symbol_is_used_symbol_id_ branch from 362d96b to 85b8ea4 Compare February 10, 2025 06:22
Copy link
Contributor

graphite-app bot commented Feb 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-10-feat_minifier_remove_unused_class_expression_by_remove_dead_code branch from 685222e to 3f7faed Compare February 10, 2025 06:22
Base automatically changed from 02-10-refactor_minifier_extract_symbols_.symbol_is_used_symbol_id_ to main February 10, 2025 06:32
@graphite-app graphite-app bot merged commit 3f7faed into main Feb 10, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-10-feat_minifier_remove_unused_class_expression_by_remove_dead_code branch February 10, 2025 06:40
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #8996 will not alter performance

Comparing 02-10-feat_minifier_remove_unused_class_expression_by_remove_dead_code (3f7faed) with main (d515cfd)

Summary

✅ 33 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant