-
-
Notifications
You must be signed in to change notification settings - Fork 617
feat(minifier): remove unused function expression with name by remove_dead_code #8996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
02-10-feat_minifier_remove_unused_class_expression_by_remove_dead_code
Feb 10, 2025
Merged
feat(minifier): remove unused function expression with name by remove_dead_code #8996
graphite-app
merged 1 commit into
main
from
02-10-feat_minifier_remove_unused_class_expression_by_remove_dead_code
Feb 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
Merged
…_dead_code (#8996) I think whether the `name` exists or not does not affect whether the function expression can be removed or not because the name can only be referenced inside that function.
362d96b
to
85b8ea4
Compare
Merge activity
|
685222e
to
3f7faed
Compare
Base automatically changed from
02-10-refactor_minifier_extract_symbols_.symbol_is_used_symbol_id_
to
main
February 10, 2025 06:32
CodSpeed Performance ReportMerging #8996 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-minifier
Area - Minifier
C-enhancement
Category - New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think whether the
name
exists or not does not affect whether the function expression can be removed or not because the name can only be referenced inside that function.