Bump API for versioning #2984
Draft
Bump API for versioning #2984
+854
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With oxidecomputer/omicron#9430, the external API is now versioned. In #2981 we bumped the client generator to pass the version header. In this change we update the client generation script because instead of pointing at
omicron/openapi/nexus.json, there is now a symlink atomicron/openapi/nexus/nexus-latest.jsonthat tells us which file the actual spec is in. I don't know if there's some way to get GitHub to follow the symlink for you, but it's simple enough to fetch the symlink to get the target file and then fetch the target file.The actual API changes coming in here are more interesting and are why this is a draft.
disk_typefield that has one possible value —crucible— but in Local storage 2/4: Add the new disk type omicron#9409 that is going to change todistributed/local, so maybe we don't want to bother putting it in as crucible yet.There are a bunch of endpoints added around multicast groups. Those are fine, but we're getting a type error in the generated Zod validators used by the mock server to validate request bodies. Most likely this is a generator bug, but sometimes it means the types in the schema are suboptimal. I need to look into that.Fixed in Handle nullable arrays in zod validators oxide.ts#317 and brought in in fe507b4