-
Notifications
You must be signed in to change notification settings - Fork 19
Update to new networking API shape, with IPv6 #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charliepark
wants to merge
42
commits into
main
Choose a base branch
from
ipv6_migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,964
−751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates console to work with the new API shape for IP pool selection introduced in oxidecomputer/omicron#9598 and other Omicron PRs.
I'll go over the main changes and how they relate to Console, both for us and for aipr as we go through it. There are still a few decisions to make in terms of forms / UI, but I'll try to note those as well.
Claude's summary of the changes in this PR:
Key API Shape Changes
Before:
pool?: NameOrId | null
After:
poolSelector?: PoolSelector // discriminated union
type PoolSelector =
| { type: 'explicit'; pool: NameOrId }
| { type: 'auto'; ipVersion?: IpVersion | null } // Required when dual defaults exist
Why: Enables explicit IPv4 vs IPv6 selection when both default pools exist.
Before:
// Single IP + transit IPs
ip?: string
transitIps?: IpNet[]
After:
// Discriminated union supporting v4-only, v6-only, or dual-stack
ipConfig?: PrivateIpStackCreate
type PrivateIpStackCreate =
| { type: 'v4'; value: PrivateIpv4StackCreate }
| { type: 'v6'; value: PrivateIpv6StackCreate }
| { type: 'dual_stack'; value: { v4: ..., v6: ... } }
Each stack has ip: Ipv4Assignment | Ipv6Assignment (auto or explicit) and version-specific transitIps.
Before:
type: 'default' // Single default option
After:
type: 'default_ipv4' | 'default_ipv6' | 'default_dual_stack'
Why: Explicit control over default interface IP version(s).
Before: Max 1 default pool per silo
After: Max 4 defaults per silo:
Added poolType: 'unicast' | 'multicast' field:
UI/Form Impact Summary
New Component: IpPoolSelector – radio-button UI for "IPv4 default" / "IPv6 default" / "custom pool" selection with version filtering.
Also, a quick note on selecting Ephemeral IPs for instances: