Skip to content

Commit

Permalink
Add comments explaining production assumption
Browse files Browse the repository at this point in the history
We currently have an implicit assumption that our production images
have the same name as the board. It's useful to take advantage of this
in places like the control plane so document this for our future
selves.
  • Loading branch information
labbott committed Sep 18, 2024
1 parent 37f6a1f commit cc99111
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/gimlet/rev-b.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "gimlet-b"
board = "gimlet-b"
inherit = "base.toml"
Expand Down
1 change: 1 addition & 0 deletions app/gimlet/rev-c.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "gimlet-c"
board = "gimlet-c"

Expand Down
2 changes: 2 additions & 0 deletions app/gimlet/rev-d.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# The rev D hardware includes `nreset` lines on all I2C muxes and changes the
# M.2 device type from `m2_hp_only` to `nvme_bmc` (after a hardware fix).
#
# This is the production image. We expect `name` to match `board`
name = "gimlet-d"
board = "gimlet-d"
inherit = "base.toml"
Expand Down
1 change: 1 addition & 0 deletions app/gimlet/rev-e.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "gimlet-e"
board = "gimlet-e"

Expand Down
1 change: 1 addition & 0 deletions app/gimlet/rev-f.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "gimlet-f"
board = "gimlet-f"

Expand Down
1 change: 1 addition & 0 deletions app/oxide-rot-1/app.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "oxide-rot-1"
target = "thumbv8m.main-none-eabihf"
board = "oxide-rot-1"
Expand Down
1 change: 1 addition & 0 deletions app/psc/rev-b.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "psc-b"
board = "psc-b"

Expand Down
1 change: 1 addition & 0 deletions app/psc/rev-c.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "psc-c"
board = "psc-c"

Expand Down
1 change: 1 addition & 0 deletions app/sidecar/rev-b.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "sidecar-b"
board = "sidecar-b"
inherit = "base.toml"
Expand Down
1 change: 1 addition & 0 deletions app/sidecar/rev-c.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "sidecar-c"
board = "sidecar-c"
inherit = "base.toml"
Expand Down
1 change: 1 addition & 0 deletions app/sidecar/rev-d.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the production image. We expect `name` to match `board`
name = "sidecar-d"
board = "sidecar-d"

Expand Down

0 comments on commit cc99111

Please sign in to comment.