Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop gdb file from the archive #1891

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Drop gdb file from the archive #1891

merged 2 commits into from
Oct 7, 2024

Conversation

labbott
Copy link
Collaborator

@labbott labbott commented Oct 2, 2024

This file contains local paths which reduces reproducibility. The local paths also mean it's not useful in the archive anyway.

This file contains local paths which reduces reproducibility.
The local paths also mean it's not useful in the archive anyway.
@mkeeter
Copy link
Collaborator

mkeeter commented Oct 2, 2024

This will break humility gdb with

GDB script missing. Is your Hubris build too old?

(ironically)

Since it changes Humility compatibility, it should technically be a Hubris version bump. I don't feel too pedantic about it, though, since folks usually aren't using humility gdb; curious to hear other opinions.

Either way, we probably want a new --gdb-script argument to humility gdb, so it can either pull the script from the archive or use a local script.

@labbott
Copy link
Collaborator Author

labbott commented Oct 2, 2024

I had forgotten humility gdb was even a thing (and here I was running it manually...). I'm inclined to let this break with an error message to pass the script in manually in humility.

@cbiffle
Copy link
Collaborator

cbiffle commented Oct 3, 2024

As probably the main user of humility gdb at this point, I'd be comfortable updating the Humility error message to read

GDB script missing; recent archives don't include it. Pass --gdb-script

and not rev the archive version.

@cbiffle
Copy link
Collaborator

cbiffle commented Oct 3, 2024

Better yet...

GDB script missing; recent archives don't include it because humility gdb is deprecated, use xtask gdb

@labbott
Copy link
Collaborator Author

labbott commented Oct 4, 2024

oxidecomputer/humility#510 associated humility change

@labbott labbott merged commit eeaf69f into master Oct 7, 2024
106 checks passed
@labbott labbott deleted the fix_gdb branch October 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants