Avoid name conflict #1897
Merged
Avoid name conflict #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
force-pushed
the
sprot_error_conflict
branch
2 times, most recently
from
d5b2ad0
to
9651b8b
Compare
|
fixes #1896 |
Change the name `SprotError` in `attest-data` to avoid conflicts with the hubris `SprotError`. Rust handles this just fine but our external hiffy tooling does not handle this case.
labbott
force-pushed
the
sprot_error_conflict
branch
from
9651b8b
to
3bcd90a
Compare
cbiffle
approved these changes
Oct 8, 2024
mkeeter
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name
SprotErrorinattest-datato avoid conflicts with the hubrisSprotError. Rust handles this just fine but our external hiffy tooling does not handle this case.