Add control-plane-agent and host-sp-comms to Grapefruit
#1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1793 |
mkeeter
force-pushed
the
grapefruit-control-plane-agent
branch
2 times, most recently
from
9301406
to
003218c
Compare
lgtm and works on hardware with the uart looped through the FPGA. |
nathanaelhuffman
approved these changes
Oct 10, 2024
jgallagher
approved these changes
Oct 11, 2024
| description: "Cosmo SP5 host cpu", | ||
| capabilities: DeviceCapabilities::HAS_SERIAL_CONSOLE, | ||
| presence: DevicePresence::Present, // TODO: ok to assume always present? | ||
| }, | ||
| // If we're building for gimlet, we always claim to have host boot flash. |
There was a problem hiding this comment.
Suggested change
| // If we're building for gimlet, we always claim to have host boot flash. | |
| // If we're building for a compute sled, we always claim to have host boot flash. |
task/host-sp-comms/src/main.rs
Outdated
| @@ -1558,6 +1575,10 @@ cfg_if::cfg_if! { | |||
| // gimletlet doesn't have an SP3 to interrupt, but we can wire up an LED | |||
| // to one of the exposed E2-E6 pins to see it visually. | |||
| const SP_TO_SP3_INT_L: sys_api::PinSet = sys_api::Port::E.pin(2); | |||
| } else if #[cfg(target_board = "grapefruit")] { | |||
| // we don't have an SP3 interrupt pin, so pick an unconnected GPIO | |||
| // TODO this is specific to SP3; but SP5 is coming! | |||
There was a problem hiding this comment.
Is this "the name of the constant is wrong" or "we don't yet know which pin will be used for interrupts" or both?
There was a problem hiding this comment.
Both! We should probably rename the constant to something like SP_TO_HOST_CPU_INT_L, but we also don't have any SP5 boards that actually use this pin (since Grapefruit doesn't have it wired up). That will come in a future #[cfg(target_board = "cosmo")] block.
There was a problem hiding this comment.
On second though, I can do the renaming here (552e195)
mkeeter
force-pushed
the
grapefruit-control-plane-agent
branch
from
003218c
to
420caa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gimlet_seqtocpu_seqin Idol and API crates, and use it for both Gimlet and Grapefruitgrapefruit-seq-serverto do mock power control, likemock-gimlet-seq-servergimletBSP incontrol-plane-agenttocpu-sled, and use it for both Gimlet and Cosmousart6support tohost-sp-comms, since that's what Grapefruit useshost-sp-comms,control-plane-agent, andstm32h7-update-servertograpefruit/app.tomlcontrol-plane-agentandhost-sp-commsOpening as a draft because this depends on oxidecomputer/management-gateway-service#297