diagnose: support newer kernels #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `humility diagnose` command contains its own code for looking up the task table. This code only uses the `TASK_TABLE_BASE` symbol used by older kernels, and does not look for the `TASK_TABLE_SPACE` symbol used by newer kernels. This means that on a recent kernel, the `diagnose` command will fail: ```console $ humility -t gimletlet diagnose humility: attached to 0483:3754:000B00154D46501520383832 via ST-Link V3 --- Initial Inspection --- Taking initial snapshot of task status... humility diagnose failed: expected symbol TASK_TABLE_BASE not found ``` This commit changes `humility diagnose` to use the `HubrisArchive::task_table` method to look up the task table, instead. Unlike the previous code, this method will look for both the `TASK_TABLE_BASE` and `TASK_TABLE_SIZE` symbols of older kernels, _and_ the `TASK_TABLE_SPACE` symbol of newer kernels. Now, it works for my recent Hubris build: ```console $ humility -t gimletlet diagnose humility: attached to 0483:3754:000B00154D46501520383832 via ST-Link V3 --- Initial Inspection --- Taking initial snapshot of task status... System last rebooted 791183 ticks ago; assuming tick=millisecond, 791.183s ago Snapshot taken, 25 tasks in application. --- Tasks: First Pass --- Checking for any suspicious task attributes... --- Advancing Time --- Resuming core for a bit... Core halted after 1001 more ticks. --- Tasks: Second Pass --- --- Generating Coredump --- humility: dumping to hubris.core.0 humility: dumped 731.46KB in 29 seconds Leaving CPU halted in case you want to inspect. --- End Of Report --- ``` Fixes #483
the error from `task_table` is actually already more descriptive
bcantrill
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
humility diagnosecommand contains its own code for looking up the task table. This code only uses theTASK_TABLE_BASEsymbol used by older kernels, and does not look for theTASK_TABLE_SPACEsymbol used by newer kernels. This means that on a recent kernel, thediagnosecommand will fail:This commit changes
humility diagnoseto use theHubrisArchive::task_tablemethod to look up the task table, instead. Unlike the previous code, this method will look for both theTASK_TABLE_BASEandTASK_TABLE_SIZEsymbols of older kernels, and theTASK_TABLE_SPACEsymbol of newer kernels. Now, it works for my recent Hubris build:Fixes #483