Better backtraces from stack overflows #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
changed the title
mkeeter
force-pushed
the
better-overflow-backtrace
branch
2 times, most recently
from
26c2d37
to
2991400
Compare
labbott
approved these changes
Oct 9, 2024
mkeeter
force-pushed
the
stack-overflow-core
branch
2 times, most recently
from
b81931f
to
53cab04
Compare
mkeeter
force-pushed
the
better-overflow-backtrace
branch
from
2991400
to
b135dea
Compare
mkeeter
force-pushed
the
better-overflow-backtrace
branch
from
b135dea
to
1d571a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Staged on top of #508)
This PR adds a new
--guessargument tohumility tasks, which tries to use the saved frame pointer to get a stack trace under exceptional circumstances. I deliberately implemented it as a suspicious-sounding flag instead of an automatic fallback, because it may not be 100% reliable (but it looks fine in all of the unit tests).The PR is split into two standalone commits: