Run "nightly" build on every merge to master. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we run the nightly build once per day, as its name implies. The main use for the nightly build is distributing its artifact (a Humility binary) to other builders, for use in testing compatibility in e.g. the Hubris build. This means that currently, merging any change that affects archive compatibility involves a mandatory 24-ish hour waiting period between merging the Humility support, and changing Hubris. This is annoying, and is a great way to have me wander off and forget what I was doing (right now it's a Friday, so I'd have to come back on Monday to finish merging). Waiting for computers is dumb. This commit changes the "nightly" build to re-run and re-clobber the release on every successful merge to master. We've been merging to Humility master far less than once per day, so this will not meaningfully increase the number of builds run. This also makes the name of the release slightly wrong, but I would like to justify leaving it as-is for three reasons: 1. It's always night somewhere. 2. Most "nightly" builds will still be triggered by cron. 3. Identifying what scripts in other repos depend on this release name seems rather difficult.
|
If it does something really lame, we'll reverse it! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run the nightly build once per day, as its name implies. The main use for the nightly build is distributing its artifact (a Humility binary) to other builders, for use in testing compatibility in e.g. the Hubris build.
This means that currently, merging any change that affects archive compatibility involves a mandatory 24-ish hour waiting period between merging the Humility support, and changing Hubris. This is annoying, and is a great way to have me wander off and forget what I was doing (right now it's a Friday, so I'd have to come back on Monday to finish merging). Waiting for computers is dumb.
This commit changes the "nightly" build to re-run and re-clobber the release on every successful merge to master. We've been merging to Humility master far less than once per day, so this will not meaningfully increase the number of builds run.
This also makes the name of the release slightly wrong, but I would like to justify leaving it as-is for three reasons: