Add support for dual-stack external addressing #9470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Dec 4, 2025
bnaecker
commented
- Adds enum for tracking the external IP addresses for an instance or service, which includes the three fields that were previously separate: SNAT, ephemeral, and list of floating addresses.
- Makes the previous source NAT config type IP address specific, with a "generic" variant for services. This is a bit lazy, but we can lift the IP version out of the contained IP address and into the source NAT type itself in the future if we need to.
- Add new version of the sled-agent API with these new types, plus conversions with the previous version
- Completely handle dual-stack OPTE ports, closes Enable dual-stack OPTE ports in the sled-agent #9247
- Closes Guest external IP configuration needs to be dual-stack #9318
bnaecker
force-pushed
the
dual-stack-external-addressing
branch
5 times, most recently
from
078e09b to
0000088
Compare
bnaecker
commented
Dec 4, 2025
Comment on lines
+2377
to
+2372
| let mut seen_snat_ip = false; | ||
| let mut seen_ephemeral_ip = false; |
Collaborator
Author
There was a problem hiding this comment.
Might be better to put this kind of validation into the builder, e.g., add checked methods that fail if the caller tries to overwrite existing values.
- Adds enum for tracking the external IP addresses for an instance or service, which includes the three fields that were previously separate: SNAT, ephemeral, and list of floating addresses. - Makes the previous source NAT config type IP address specific, with a "generic" variant for services. This is a bit lazy, but we can lift the IP version out of the contained IP address and into the source NAT type itself in the future if we need to. - Add new version of the sled-agent API with these new types, plus conversions with the previous version - Completely handle dual-stack OPTE ports, closes #9247 - Closes #9318
bnaecker
force-pushed
the
dual-stack-external-addressing
branch
from
0000088 to
4774e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.