Bump golangci. #363
Merged
Bump golangci. #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using an older version of golang-ci. This patch updates to latest, adds linting and formatting for long lines, and disables the errcheck linter due to noise. We also replace the previous `make fmt` target, which ran a linter rather than a formatter.
Merged
sudomateo
approved these changes
Jan 14, 2026
Collaborator
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
Looks great! I'll spin out an issue on Go tool dependencies based on the comment I left here.
Comment on lines
+38
to
+40
| fmt: tools ## Formats Go code including long line wrapping. | ||
| @ echo "+ Formatting Go code..." | ||
| @ $(GOBIN)/golangci-lint fmt |
Collaborator
There was a problem hiding this comment.
Definitely not for this pull request but I've been giving a bit of thought to how we use tools in our Go projects. Go 1.24 introduced support for tool dependencies where we can run tools using go tool that are versioned in go.mod separately from our normal dependencies. I'd love for us to switch to something like that rather than maintaining some VERSION_* env vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using an older version of golang-ci. This patch updates to latest, adds linting and formatting for long lines, and disables the errcheck linter due to noise. We also replace the previous
make fmttarget, which ran a linter rather than a formatter.