feat(oxide_instance): read-only attribute to show instance external ips #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudomateo
commented
Dec 20, 2025
| Computed: true, | ||
| Description: "Timestamp of when this instance was last modified.", | ||
| }, | ||
| "external_ip_info": schema.SingleNestedAttribute{ |
Collaborator
Author
There was a problem hiding this comment.
I'm not sold on the attribute name or schema. The map approach is nice for grouping external IP types, but it gets us away from the API design a bit.
Added a new computed attribute to `oxide_instance` that exposes the external IP addresses for the instance. This should allow users to use a provisioner with the `oxide_instance` resource, though further testing is needed. Amp-Thread: https://ampcode.com/threads/T-019b39f4-0dc1-708b-9b75-ba69bf65c73c Closes SSE-75. Relates to SSE-64.
sudomateo
force-pushed
the
sudomateo/uytluxusyrvn
branch
from
57e9765 to
7491835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new computed attribute to
oxide_instancethat exposes the external IP addresses for the instance. This should allow users to use a provisioner with theoxide_instanceresource, though further testing is needed.Amp-Thread: https://ampcode.com/threads/T-019b39f4-0dc1-708b-9b75-ba69bf65c73c
Closes SSE-75.
Relates to SSE-64.
Pull request checklist