Cache oxide.rs by version. #605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Look up the correct version of oxide.rs for the current VERSION_OMICRON. We can't assume that the `main` branch of this repo always corresponds to oxide.rs@main, so we look up the expected version of the openapi spec and page through oxide.rs commits until we find one with a matching version in its oxide.json. * Cache the oxide.rs binary by its commit hash. Building from source can take 4-5 minutes on shared workers, so we save a meaningful amount of time by caching.
jmcarp
force-pushed
the
jmcarp/cache-oxide-rs
branch
from
83344c4 to
c5a76c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch of this repo always corresponds to oxide.rs@main, so we look up the expected version of the openapi spec and page through oxide.rs commits until we find one with a matching version in its oxide.json.Extracting from #604 for easier review.